Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support
@ 2014-03-06 20:55 Gustavo Zacarias
  2014-03-06 20:55 ` [Buildroot] [PATCH 2/2] fs/iso9660: fix iso9660 support Gustavo Zacarias
  2014-03-06 22:02 ` [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2014-03-06 20:55 UTC (permalink / raw)
  To: buildroot

On commit a24877586a566e052897e50e6a0c2f53cfb029f TARGETS_ROOTFS was
introduced, however fs/initramfs/initramfs.mk was never updated, hence a
show-targets would be rootfs-initramfs with rootfs-cpio afterwards hence
never rebuilding the kernel with a proper cpio archive since TARGETS is
always before rootfs-* as stated in the commit description.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 fs/initramfs/initramfs.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/initramfs/initramfs.mk b/fs/initramfs/initramfs.mk
index 7820d65..5d3ea89 100644
--- a/fs/initramfs/initramfs.mk
+++ b/fs/initramfs/initramfs.mk
@@ -18,5 +18,5 @@ rootfs-initramfs-show-depends:
 	@echo $(ROOTFS_INITRAMFS_DEPENDENCIES)
 
 ifeq ($(BR2_TARGET_ROOTFS_INITRAMFS),y)
-TARGETS += rootfs-initramfs
+TARGETS_ROOTFS += rootfs-initramfs
 endif
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] fs/iso9660: fix iso9660 support
  2014-03-06 20:55 [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Gustavo Zacarias
@ 2014-03-06 20:55 ` Gustavo Zacarias
  2014-03-06 22:02 ` [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2014-03-06 20:55 UTC (permalink / raw)
  To: buildroot

Similar to the "fs/initramfs: fix initramfs support" commit the same
problem applies to iso9660 in a different way. By adding iso9660 to
TARGETS it gets called before target-finalize with obvious consequences.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 fs/iso9660/iso9660.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
index a6a9c95..6c8ace0 100644
--- a/fs/iso9660/iso9660.mk
+++ b/fs/iso9660/iso9660.mk
@@ -47,5 +47,5 @@ rootfs-iso9660: $(BINARIES_DIR)/rootfs.iso9660
 #
 ################################################################################
 ifeq ($(BR2_TARGET_ROOTFS_ISO9660),y)
-TARGETS += rootfs-iso9660
+TARGETS_ROOTFS += rootfs-iso9660
 endif
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support
  2014-03-06 20:55 [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Gustavo Zacarias
  2014-03-06 20:55 ` [Buildroot] [PATCH 2/2] fs/iso9660: fix iso9660 support Gustavo Zacarias
@ 2014-03-06 22:02 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-03-06 22:02 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Thu,  6 Mar 2014 17:55:34 -0300, Gustavo Zacarias wrote:
> On commit a24877586a566e052897e50e6a0c2f53cfb029f TARGETS_ROOTFS was
> introduced, however fs/initramfs/initramfs.mk was never updated, hence a
> show-targets would be rootfs-initramfs with rootfs-cpio afterwards hence
> never rebuilding the kernel with a proper cpio archive since TARGETS is
> always before rootfs-* as stated in the commit description.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  fs/initramfs/initramfs.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-06 22:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 20:55 [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Gustavo Zacarias
2014-03-06 20:55 ` [Buildroot] [PATCH 2/2] fs/iso9660: fix iso9660 support Gustavo Zacarias
2014-03-06 22:02 ` [Buildroot] [PATCH 1/2] fs/initramfs: fix initramfs support Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox