[Buildroot] [PATCH v2] pyrex: new host package

[Buildroot] [PATCH v2] pyrex: new host package

[rc.lsw.collaborate at gmail.com]

From: mlweber <mlweber@localhost>

This patch is a revision of the v1, found here:
http://patchwork.ozlabs.org/patch/276585/

For v2, I made a first attempt at making this a host only pkg. Feedback would
be much appreciated since being a host only package a Config.in.host was
used and I still included it in the normal Python submenu as that seemed to
be the clearest location.  Also in the naming of the menu entry I provided
a "(host tool)" for clarification.

Thanks!

Matt Weber (1):
  pyrex: new package

 package/Config.in                    |    1 +
 package/python-pyrex/Config.in.host  |    7 +++++++
 package/python-pyrex/python-pyrex.mk |   15 +++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/python-pyrex/Config.in.host
 create mode 100644 package/python-pyrex/python-pyrex.mk

--
1.7.9.5

[Buildroot] [PATCH v2] pyrex: new host package

[rc.lsw.collaborate at gmail.com]

From: Matt Weber <mlweber1@rockwellcollins.com>

Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
---
Changes v1 -> v2:
   - Converted to a host only pkg as this pkg provides generated
     C code that an application would use from a sysroot
     (not on target).  (Suggested by Thomas)
---
 package/Config.in                    |    1 +
 package/python-pyrex/Config.in.host  |    7 +++++++
 package/python-pyrex/python-pyrex.mk |   15 +++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/python-pyrex/Config.in.host
 create mode 100644 package/python-pyrex/python-pyrex.mk

diff --git a/package/Config.in b/package/Config.in
index 70e5a7f..cec0fea 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -454,6 +454,7 @@ source "package/python-pyasn/Config.in"
 source "package/python-pycrypto/Config.in"
 source "package/python-pygame/Config.in"
 source "package/python-pyparsing/Config.in"
+source "package/python-pyrex/Config.in.host"
 source "package/python-pyro/Config.in"
 source "package/python-pysnmp/Config.in"
 source "package/python-pysnmp-apps/Config.in"
diff --git a/package/python-pyrex/Config.in.host b/package/python-pyrex/Config.in.host
new file mode 100644
index 0000000..ff83daf
--- /dev/null
+++ b/package/python-pyrex/Config.in.host
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_HOST_PYTHON_PYREX
+	bool "python-pyrex (host tool)"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  Pyrex is a language for writing Python extension modules
+
+	  http://www.cosc.canterbury.ac.nz/greg.ewing/python/Pyrex/
diff --git a/package/python-pyrex/python-pyrex.mk b/package/python-pyrex/python-pyrex.mk
new file mode 100644
index 0000000..73cb163
--- /dev/null
+++ b/package/python-pyrex/python-pyrex.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-pyrex
+#
+################################################################################
+
+PYTHON_PYREX_VERSION = 0.9.9
+PYTHON_PYREX_SOURCE = Pyrex-$(PYTHON_PYREX_VERSION).tar.gz
+PYTHON_PYREX_SITE = http://www.cosc.canterbury.ac.nz/greg.ewing/python/Pyrex/
+PYTHON_PYREX_DEPENDENCIES = host-python
+PYTHON_PYREX_LICENSE = Apache-v2
+PYTHON_PYREX_LICENSE_FILES = LICENSE.txt
+PYTHON_PYREX_SETUP_TYPE = distutils
+
+$(eval $(host-python-package))
--
1.7.9.5

[Buildroot] [PATCH v2] pyrex: new host package

[Yann E. MORIN]

On 2014-03-14 17:58 -0500, rc.lsw.collaborate at gmail.com spake thusly:
> From: mlweber <mlweber@localhost>
> 
> This patch is a revision of the v1, found here:
> http://patchwork.ozlabs.org/patch/276585/

Thanks, I've marked it as "Superseded". It's nice you provided the URL
of the previous patch, it made it easy-as-a-snap to find it. :-)

> For v2, I made a first attempt at making this a host only pkg. Feedback would
> be much appreciated since being a host only package a Config.in.host was
> used and I still included it in the normal Python submenu as that seemed to
> be the clearest location.  Also in the naming of the menu entry I provided
> a "(host tool)" for clarification.

I think we would prefer that all host-only tools be located in the "Host
utilities" menu, rather than spread around in the different menus.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2] pyrex: new host package

[Yann E. MORIN]

Matt, All,

On 2014-03-14 17:58 -0500, rc.lsw.collaborate at gmail.com spake thusly:
> From: Matt Weber <mlweber1@rockwellcollins.com>

Could you add in the commit log what Pyrex is and why it would be needed
as a host-only package?

I can read the description in the help text, but that does not say why
it is interesting to have Pyrex as a host-tool in Buildroot.

Also, you're not adding any in-tree user of host-pyrex (maybe you have
one or two such packages ready to be submitted? ;-) ), which does not
help to understand why it is needed.

(Note: even if you provide such ackages, please expand this commit log
anyway.)

> Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
> ---
> Changes v1 -> v2:
>    - Converted to a host only pkg as this pkg provides generated
>      C code that an application would use from a sysroot
>      (not on target).  (Suggested by Thomas)
> ---
>  package/Config.in                    |    1 +
>  package/python-pyrex/Config.in.host  |    7 +++++++
>  package/python-pyrex/python-pyrex.mk |   15 +++++++++++++++
>  3 files changed, 23 insertions(+)
>  create mode 100644 package/python-pyrex/Config.in.host
>  create mode 100644 package/python-pyrex/python-pyrex.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 70e5a7f..cec0fea 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -454,6 +454,7 @@ source "package/python-pyasn/Config.in"
>  source "package/python-pycrypto/Config.in"
>  source "package/python-pygame/Config.in"
>  source "package/python-pyparsing/Config.in"
> +source "package/python-pyrex/Config.in.host"

As I said in my reply to your cover-letter: we want to have all
host-only packages in the "Host utilities" sub-menu.

_But_ if this package is going to be used by other in-tree packages,
there is no real need to add an entry in the "Host utilities" menu.

We only add entries in that menu if a host tool may also be used outside
of the Buildroot infrastructure. For example, the file system generators
might be used by post-imnage scripts, so we expose them.

But for purely internal host tools, we usually do not expose an entry
for them.

>  source "package/python-pyro/Config.in"
>  source "package/python-pysnmp/Config.in"
>  source "package/python-pysnmp-apps/Config.in"
> diff --git a/package/python-pyrex/Config.in.host b/package/python-pyrex/Config.in.host
> new file mode 100644
> index 0000000..ff83daf
> --- /dev/null
> +++ b/package/python-pyrex/Config.in.host
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_HOST_PYTHON_PYREX
> +	bool "python-pyrex (host tool)"

When you move this package to the "Host utilities" menu, change the
prompt to simply:
    "host pyrex"

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2] pyrex: new host package

[Matt Weber]

Hi,
On Fri, Mar 14, 2014 at 6:20 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Matt, All,
>
> On 2014-03-14 17:58 -0500, rc.lsw.collaborate at gmail.com spake thusly:
>> From: Matt Weber <mlweber1@rockwellcollins.com>
>
> Could you add in the commit log what Pyrex is and why it would be needed
> as a host-only package?
Sure, I'll submit v3 and include a good description.

> I can read the description in the help text, but that does not say why
> it is interesting to have Pyrex as a host-tool in Buildroot.
>
> Also, you're not adding any in-tree user of host-pyrex (maybe you have
> one or two such packages ready to be submitted? ;-) ), which does not
> help to understand why it is needed.
I've got a pkg almost ready to submit that wrappers the libpcap
library with this
framework.  I should be able to test it on target in a couple days and then
submit that new pkg patch.

Thanks for the review!
Matt