Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] package/vlc: depends on the virtual package libgl
Date: Wed, 2 Apr 2014 18:26:53 +0200	[thread overview]
Message-ID: <20140402162653.GB3509@free.fr> (raw)
In-Reply-To: <533BABEA.4030802@mind.be>

Arnout, All,

On 2014-04-02 08:19 +0200, Arnout Vandecappelle spake thusly:
> On 01/04/14 00:00, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > Currently, vlc depends on mesa3d to provide the openGL support.
> > 
> > We now have a virtual package, libgl, which ensures openGL is available.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Bernd Kuhls <berndkuhls@hotmail.com>
> > ---
> >  package/vlc/vlc.mk | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
> > index a9ee620..f78f209 100644
> > --- a/package/vlc/vlc.mk
> > +++ b/package/vlc/vlc.mk
> > @@ -118,9 +118,9 @@ else
> >  VLC_CONF_OPT += --disable-flac
> >  endif
> >  
> > -ifeq ($(BR2_PACKAGE_MESA3D),y)
> > +ifeq ($(BR2_PACKAGE_HAS_OPENGL),y)
> >  VLC_CONF_OPT += --enable-glx
> 
>  Since the option is called enable-glx, it sounds as if it should depend
> on X as well (I don't think wayland has glx, right?)

Well, full-openGL is only possible with X11 anyway, so BR2_PACKAGE_HAS_OPENGL
will itself not be set when X.org is not selected as well.

So, I think we can just depend on BR2_PACKAGE_HAS_OPENGL for this
option.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-04-02 16:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 21:59 [Buildroot] [PATCH 0/6] Add virtual package for full-openGL (branch yem/fixes) Yann E. MORIN
2014-03-31 21:59 ` [Buildroot] [PATCH 1/6] package/libevas: quick fix to get rid of circular deps Yann E. MORIN
2014-04-02  6:13   ` Arnout Vandecappelle
2014-04-02 16:25     ` Yann E. MORIN
2014-04-03 20:43   ` Thomas Petazzoni
2014-03-31 21:59 ` [Buildroot] [PATCH 2/6] package/libgl: introduce as a new virtual package for full-openGL providers Yann E. MORIN
2014-03-31 21:59 ` [Buildroot] [PATCH 3/6] package/mesa3d: is a full-openGL provider if X.org is present Yann E. MORIN
2014-04-01  7:48   ` Paul Cercueil
2014-04-01 18:14     ` Yann E. MORIN
2014-04-01 20:14       ` Paul Cercueil
2014-04-01 21:20         ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 4/6] package/vlc: depends on the virtual package libgl Yann E. MORIN
2014-04-02  6:19   ` Arnout Vandecappelle
2014-04-02 16:26     ` Yann E. MORIN [this message]
2014-04-03  6:18       ` Arnout Vandecappelle
2014-04-03 17:01         ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 5/6] package/x11-video-drivers: do not select, but depends on mesa3d Yann E. MORIN
2014-04-02 20:01   ` Bernd Kuhls
2014-04-03 17:03     ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 6/6] package/xorg-server: do not force-select xf86driproto for mesa3d Yann E. MORIN
2014-04-01 19:11 ` [Buildroot] [PATCH 0/6] Add virtual package for full-openGL (branch yem/fixes) Eric Le Bihan
2014-04-01 23:00 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402162653.GB3509@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox