From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] package/libevas: quick fix to get rid of circular deps
Date: Wed, 02 Apr 2014 08:13:05 +0200 [thread overview]
Message-ID: <533BAA71.4050104@mind.be> (raw)
In-Reply-To: <eb47cebc21e1bc07000dd375c77a28b362e281e0.1396302677.git.yann.morin.1998@free.fr>
On 31/03/14 23:59, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> This is a quick workaround against the recently-introduced circular
> dependencies hell:
>
> package/xbmc/Config.in:10:error: recursive dependency detected!
> package/xbmc/Config.in:10: symbol BR2_PACKAGE_XBMC depends on BR2_PACKAGE_HAS_OPENGL_EGL
> package/opengl/libegl/Config.in:1: symbol BR2_PACKAGE_HAS_OPENGL_EGL is selected by BR2_PACKAGE_MESA3D_OPENGL_EGL
> package/mesa3d/Config.in:92: symbol BR2_PACKAGE_MESA3D_OPENGL_EGL depends on BR2_PACKAGE_MESA3D
> package/mesa3d/Config.in:1: symbol BR2_PACKAGE_MESA3D is selected by BR2_PACKAGE_LIBEVAS_GL
> package/efl/libevas/Config.in:149: symbol BR2_PACKAGE_LIBEVAS_GL is part of choice <choice>
> package/efl/libevas/Config.in:144: choice <choice> contains symbol <choice>
> package/efl/libevas/Config.in:144: choice <choice> contains symbol BR2_PACKAGE_LIBEVAS_SDL_GL
> package/efl/libevas/Config.in:90: symbol BR2_PACKAGE_LIBEVAS_SDL_GL depends on BR2_PACKAGE_SDL_X11
> package/sdl/Config.in:24: symbol BR2_PACKAGE_SDL_X11 depends on BR2_PACKAGE_SDL
> package/sdl/Config.in:1: symbol BR2_PACKAGE_SDL is selected by BR2_PACKAGE_PYTHON_PYGAME
> package/python-pygame/Config.in:1: symbol BR2_PACKAGE_PYTHON_PYGAME depends on BR2_PACKAGE_PYTHON
> package/python/Config.in:1: symbol BR2_PACKAGE_PYTHON is selected by BR2_PACKAGE_XBMC
>
> Until this is properly fixed with the addition of a virtual package for
> full-openGL providers, just depend on mesa3d instead of selecting it.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <berndkuhls@hotmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This should indeed go in quickly!
But shouldn't your series also include a patch that undoes this change?
Regards,
Arnout
> ---
> package/efl/libevas/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/efl/libevas/Config.in b/package/efl/libevas/Config.in
> index 2afa888..8eea23d 100644
> --- a/package/efl/libevas/Config.in
> +++ b/package/efl/libevas/Config.in
> @@ -148,7 +148,7 @@ choice
>
> config BR2_PACKAGE_LIBEVAS_GL
> bool "generic OpenGL"
> - select BR2_PACKAGE_MESA3D
> + depends on BR2_PACKAGE_MESA3D
> select BR2_PACKAGE_LIBEET
>
> config BR2_PACKAGE_LIBEVAS_GLES_SGX
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-04-02 6:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:59 [Buildroot] [PATCH 0/6] Add virtual package for full-openGL (branch yem/fixes) Yann E. MORIN
2014-03-31 21:59 ` [Buildroot] [PATCH 1/6] package/libevas: quick fix to get rid of circular deps Yann E. MORIN
2014-04-02 6:13 ` Arnout Vandecappelle [this message]
2014-04-02 16:25 ` Yann E. MORIN
2014-04-03 20:43 ` Thomas Petazzoni
2014-03-31 21:59 ` [Buildroot] [PATCH 2/6] package/libgl: introduce as a new virtual package for full-openGL providers Yann E. MORIN
2014-03-31 21:59 ` [Buildroot] [PATCH 3/6] package/mesa3d: is a full-openGL provider if X.org is present Yann E. MORIN
2014-04-01 7:48 ` Paul Cercueil
2014-04-01 18:14 ` Yann E. MORIN
2014-04-01 20:14 ` Paul Cercueil
2014-04-01 21:20 ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 4/6] package/vlc: depends on the virtual package libgl Yann E. MORIN
2014-04-02 6:19 ` Arnout Vandecappelle
2014-04-02 16:26 ` Yann E. MORIN
2014-04-03 6:18 ` Arnout Vandecappelle
2014-04-03 17:01 ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 5/6] package/x11-video-drivers: do not select, but depends on mesa3d Yann E. MORIN
2014-04-02 20:01 ` Bernd Kuhls
2014-04-03 17:03 ` Yann E. MORIN
2014-03-31 22:00 ` [Buildroot] [PATCH 6/6] package/xorg-server: do not force-select xf86driproto for mesa3d Yann E. MORIN
2014-04-01 19:11 ` [Buildroot] [PATCH 0/6] Add virtual package for full-openGL (branch yem/fixes) Eric Le Bihan
2014-04-01 23:00 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533BAA71.4050104@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox