* [Buildroot] [PATCH] xbmc: Fix Java dependency check
@ 2014-03-31 8:27 Maxime Hadjinlian
2014-04-02 19:30 ` Bernd Kuhls
2014-04-03 18:21 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Maxime Hadjinlian @ 2014-03-31 8:27 UTC (permalink / raw)
To: buildroot
A check for Java has been implemented in dependencies.sh, but during the
review, the name of the variable had been changed from:
BR2_HOST_NEEDS_JAVA to BR2_NEEDS_HOST_JAVA
as it is more accurate.
The change was not made in XBMC and as such, you could start the build
of XBMC without Java on your system.
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
package/xbmc/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/xbmc/Config.in b/package/xbmc/Config.in
index e078d2f..cf6a6b9 100644
--- a/package/xbmc/Config.in
+++ b/package/xbmc/Config.in
@@ -9,7 +9,7 @@ comment "xbmc requires an OpenGL ES and EGL backend"
menuconfig BR2_PACKAGE_XBMC
bool "xbmc"
- select BR2_HOST_NEEDS_JAVA
+ select BR2_NEEDS_HOST_JAVA
select BR2_PACKAGE_BOOST
select BR2_PACKAGE_BOOST_THREAD
select BR2_PACKAGE_BZIP2
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] xbmc: Fix Java dependency check
2014-03-31 8:27 [Buildroot] [PATCH] xbmc: Fix Java dependency check Maxime Hadjinlian
@ 2014-04-02 19:30 ` Bernd Kuhls
2014-04-03 18:21 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2014-04-02 19:30 UTC (permalink / raw)
To: buildroot
Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote in
news:1396254432-22594-1-git-send-email-maxime.hadjinlian at gmail.com:
> - select BR2_HOST_NEEDS_JAVA
> + select BR2_NEEDS_HOST_JAVA
Acked-by: Bernd Kuhls <bernd.kuhls@t-online.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] xbmc: Fix Java dependency check
2014-03-31 8:27 [Buildroot] [PATCH] xbmc: Fix Java dependency check Maxime Hadjinlian
2014-04-02 19:30 ` Bernd Kuhls
@ 2014-04-03 18:21 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-04-03 18:21 UTC (permalink / raw)
To: buildroot
Dear Maxime Hadjinlian,
On Mon, 31 Mar 2014 10:27:12 +0200, Maxime Hadjinlian wrote:
> A check for Java has been implemented in dependencies.sh, but during the
> review, the name of the variable had been changed from:
> BR2_HOST_NEEDS_JAVA to BR2_NEEDS_HOST_JAVA
> as it is more accurate.
>
> The change was not made in XBMC and as such, you could start the build
> of XBMC without Java on your system.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> package/xbmc/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-03 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 8:27 [Buildroot] [PATCH] xbmc: Fix Java dependency check Maxime Hadjinlian
2014-04-02 19:30 ` Bernd Kuhls
2014-04-03 18:21 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox