[Buildroot] [PATCH] libuci: Lua binding needs mmu and version 5.1

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Yegor Yefremov,

On Sat,  5 Apr 2014 16:36:57 +0200, Yegor Yefremov wrote:
> The Lua binding option of libuci uses fork() so it needs the MMU.
> 
> Finally, libuci fails to build with Lua 5.2 because it uses functions
> removed from this version. Fix it by activating the option only with
> Lua 5.1.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/libuci/libuci.mk | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

I've applied your patch... but I'm not really happy because you clearly
tested the patch insufficiently:

> diff --git a/package/libuci/libuci.mk b/package/libuci/libuci.mk
> index 736b946..42e61ee 100644
> --- a/package/libuci/libuci.mk
> +++ b/package/libuci/libuci.mk
> @@ -10,10 +10,14 @@ LIBUCI_LICENSE = LGPLv2.1
>  LIBUCI_INSTALL_STAGING = YES
>  LIBUCI_DEPENDENCIES = libubox
>  
> -ifeq ($(BR2_PACKAGE_LUA),y)
> -	LIBUCI_DEPENDENCIES += lua
> +ifeq ($(BR2_USE_MMU),y) # fork()
> +ifeq ($(BR2_PACKAGE_LUA_5_1),y)
> +LIBUBOX_DEPENDENCIES += lua
> +LIBUBOX_CONF_OPT += -DLUAPATH=$(STAGING_DIR)/usr/lib/lua/5.1 \
> +	-DLUA_CFLAGS=-I$(STAGING_DIR)/usr/include
>  else
> -	LIBUCI_CONF_OPT += -DBUILD_LUA:BOOL=OFF
> +LIBUBOX_CONF_OPT += -DBUILD_LUA:BOOL=OFF

LIBUBOX_* variables in libuci.mk ? Surely this cannot work.

I've fixed that and applied, but it'd be nice if patches were minimally
tested before being submitted :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com