Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hadrien Boutteville <hadrien.boutteville@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libuci: Lua binding needs mmu and version 5.1
Date: Sun, 06 Apr 2014 15:02:07 +0200	[thread overview]
Message-ID: <5341504F.1060301@gmail.com> (raw)
In-Reply-To: <1396708617-7364-1-git-send-email-yegorslists@googlemail.com>

Hello Yegor,

On Sat, 5 Apr 2014 16:36:57 +0200, Yegor Yefremov wrote:
> The Lua binding option of libuci uses fork() so it needs the MMU.

The Lua binding of libuci doesn't use fork() unlike the libubox one,
therefore the patches are not the same. You could simply check in its
source directory with:

$ ack -c --cc fork lua/
lua/uci.c:0

or

$ grep -c fork lua/uci.c
0

So it doesn't need the MMU and you can remove:

> +ifeq ($(BR2_USE_MMU),y) # fork()
>
> (...)
>
> +endif # MMU

However I agree with the other changes (corrected by Thomas), the Lua
binding of libuci suffers from the same dirty CMakeLists.txt than
libubox ;-).

Regards,

Hadrien

      parent reply	other threads:[~2014-04-06 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-05 14:36 [Buildroot] [PATCH] libuci: Lua binding needs mmu and version 5.1 Yegor Yefremov
2014-04-05 17:08 ` Thomas Petazzoni
2014-04-05 17:49   ` Yegor Yefremov
2014-04-06 13:02 ` Hadrien Boutteville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5341504F.1060301@gmail.com \
    --to=hadrien.boutteville@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox