* [Buildroot] [PATCH] libuci: fix Lua finding
@ 2014-04-05 17:46 Yegor Yefremov
2014-04-06 9:52 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Yegor Yefremov @ 2014-04-05 17:46 UTC (permalink / raw)
To: buildroot
This patch fixes Lua path comparison, if Lua is not provided.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/libuci/libuci-01-uci-fix-Lua-finding.patch | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 package/libuci/libuci-01-uci-fix-Lua-finding.patch
diff --git a/package/libuci/libuci-01-uci-fix-Lua-finding.patch b/package/libuci/libuci-01-uci-fix-Lua-finding.patch
new file mode 100644
index 0000000..f37e136
--- /dev/null
+++ b/package/libuci/libuci-01-uci-fix-Lua-finding.patch
@@ -0,0 +1,31 @@
+From 980432ce260020ed8a907b3bbc1334845ba4c4a9 Mon Sep 17 00:00:00 2001
+From: Yegor Yefremov <yegorslists@googlemail.com>
+Date: Sat, 5 Apr 2014 19:18:10 +0200
+Subject: [PATCH] uci: fix Lua finding
+
+If ${LUAPATH} is not quoted and Lua is not provided, then following
+error occurs:
+
+"NOT" "No such file or directory" "EQUAL" "0" "OR" "EQUAL" ""
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+---
+ lua/CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lua/CMakeLists.txt b/lua/CMakeLists.txt
+index e4295d7..4ba8e37 100644
+--- a/lua/CMakeLists.txt
++++ b/lua/CMakeLists.txt
+@@ -36,7 +36,7 @@ IF(NOT LUAPATH)
+ )
+
+ IF(BUILD_LUA)
+- IF(NOT ${LUA_CHECK_RES} EQUAL 0 OR ${LUAPATH} EQUAL "")
++ IF(NOT ${LUA_CHECK_RES} EQUAL 0 OR "${LUAPATH}" EQUAL "")
+ MESSAGE(SEND_ERROR "Lua was not found on your system")
+ ENDIF()
+ ENDIF()
+--
+1.8.3.2
+
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Buildroot] [PATCH] libuci: fix Lua finding
2014-04-05 17:46 [Buildroot] [PATCH] libuci: fix Lua finding Yegor Yefremov
@ 2014-04-06 9:52 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-04-06 9:52 UTC (permalink / raw)
To: buildroot
Dear Yegor Yefremov,
On Sat, 5 Apr 2014 19:46:28 +0200, Yegor Yefremov wrote:
> This patch fixes Lua path comparison, if Lua is not provided.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/libuci/libuci-01-uci-fix-Lua-finding.patch | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/libuci/libuci-01-uci-fix-Lua-finding.patch
Applied, thanks. I've added the autobuilder link, it would be good to
do it next time, as it's very useful when looking at a commit, to get a
reference to the build failure it is fixing. As an added bonus, it
ensures that you are counted as the contributors fixing autobuilder
failures that are thanked in the Buildroot release e-mail from
Peter! :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-06 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-05 17:46 [Buildroot] [PATCH] libuci: fix Lua finding Yegor Yefremov
2014-04-06 9:52 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox