Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [[RFC]] toolchain: print actual version of kernel headers when checking
Date: Sun, 6 Apr 2014 16:13:39 +0200	[thread overview]
Message-ID: <20140406141339.GC3136@free.fr> (raw)
In-Reply-To: <20140406142850.74de09ef@skate>

Thomas, All,

On 2014-04-06 14:28 +0200, Thomas Petazzoni spake thusly:
> On Sun, 30 Mar 2014 14:59:30 +0200, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> >  support/scripts/check-kernel-headers.sh | 39 ++++++++++++++++++++++++++++-----
> >  toolchain/helpers.mk                    |  3 +--
> >  2 files changed, 35 insertions(+), 7 deletions(-)
> 
> I've applied the patch with the following changes:
[--SNIP--]
> Also, I'm not entirely sure about the usage of $(uuidgen). Should we use
> mktemp instead?

Oh, probably, yes. I initially tossed that patch after Maxime enticed me
into it, so I just throw at it whatever was needed to make it work, and
then tried to clean it up.

The uuidgen part I missed when cleaning the patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2014-04-06 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-30 12:59 [Buildroot] [[RFC]] toolchain: print actual version of kernel headers when checking Yann E. MORIN
2014-03-30 13:10 ` Yann E. MORIN
2014-04-06 12:28 ` Thomas Petazzoni
2014-04-06 14:13   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140406141339.GC3136@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox