From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [[RFC]] toolchain: print actual version of kernel headers when checking
Date: Sun, 6 Apr 2014 14:28:50 +0200 [thread overview]
Message-ID: <20140406142850.74de09ef@skate> (raw)
In-Reply-To: <1396184370-4204-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 30 Mar 2014 14:59:30 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Reported-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> support/scripts/check-kernel-headers.sh | 39 ++++++++++++++++++++++++++++-----
> toolchain/helpers.mk | 3 +--
> 2 files changed, 35 insertions(+), 7 deletions(-)
I've applied the patch with the following changes:
* Modified the commit log to add the message you suggested.
* Fix the coding style: no space after opening parenthesis, no space
before closing parenthesis.
* Adjust the error message so that it fits on one line, which I
believe is clearer.
Also, I'm not entirely sure about the usage of $(uuidgen). Should we use
mktemp instead?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-06 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 12:59 [Buildroot] [[RFC]] toolchain: print actual version of kernel headers when checking Yann E. MORIN
2014-03-30 13:10 ` Yann E. MORIN
2014-04-06 12:28 ` Thomas Petazzoni [this message]
2014-04-06 14:13 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140406142850.74de09ef@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox