From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ne10: bump version to 1.0.0
Date: Sun, 13 Apr 2014 12:55:25 +0300 [thread overview]
Message-ID: <20140413095525.GD4149@tarshish> (raw)
In-Reply-To: <20140413105415.34ee1b19@skate>
Hi Thomas,
On Sun, Apr 13, 2014 at 10:54:15AM +0200, Thomas Petazzoni wrote:
> On Sun, 13 Apr 2014 11:33:56 +0300, Baruch Siach wrote:
> > diff --git a/package/ne10/Config.in b/package/ne10/Config.in
> > index d0c4983ed588..fa21cc4f084c 100644
> > --- a/package/ne10/Config.in
> > +++ b/package/ne10/Config.in
> > @@ -1,6 +1,8 @@
> > config BR2_PACKAGE_NE10
> > bool "ne10"
> > - depends on BR2_arm && BR2_ARM_CPU_HAS_NEON
> > + depends on BR2_arm
> > + depends on BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4
>
> Hum, why BR2_ARM_CPU_HAS_NEON isn't sufficient here? I believe you can
> very well have a root filesystem that is generally built with
> BR2_ARM_FPU_VFPV4 (i.e the default FPU used is VFPv4), but still build
> some software packages to use Neon instructions, as long as
> BR2_ARM_CPU_HAS_NEON is defined.
The ne10 code includes gcc arm_neon.h which requires -mfpu=neon, otherwise you
get
#error You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use arm_neon.h
The -mfpu option is hardcoded in the toolchain wrapper. Is there another way
to do this?
> > + depends on BR2_ARM_INSTRUCTIONS_THUMB || BR2_ARM_INSTRUCTIONS_THUMB2
>
> Same thing here: nothing prevents you from building your root
> filesystem with full ARM instructions (i.e
> BR2_ARM_INSTRUCTIONS_ARM_CHOICE), but still build some software
> packages to use Thumb2 instructions, as long as BR2_ARM_CPU_HAS_THUMB2
> is defined.
In this case -mthumb is hardcoded in CMakeLists.txt. Having -marm in the
toolchain wrapper confuses the linker as reported by Peter at
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/81489 .
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2014-04-13 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 8:33 [Buildroot] [PATCH v2] ne10: bump version to 1.0.0 Baruch Siach
2014-04-13 8:38 ` Baruch Siach
2014-04-13 8:54 ` Thomas Petazzoni
2014-04-13 9:55 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413095525.GD4149@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox