Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ne10: bump version to 1.0.0
Date: Sun, 13 Apr 2014 10:54:15 +0200	[thread overview]
Message-ID: <20140413105415.34ee1b19@skate> (raw)
In-Reply-To: <76642160278009c2ccd78c0d6ab5e557fd47e247.1397378036.git.baruch@tkos.co.il>

Dear Baruch Siach,

On Sun, 13 Apr 2014 11:33:56 +0300, Baruch Siach wrote:

> diff --git a/package/ne10/Config.in b/package/ne10/Config.in
> index d0c4983ed588..fa21cc4f084c 100644
> --- a/package/ne10/Config.in
> +++ b/package/ne10/Config.in
> @@ -1,6 +1,8 @@
>  config BR2_PACKAGE_NE10
>  	bool "ne10"
> -	depends on BR2_arm && BR2_ARM_CPU_HAS_NEON
> +	depends on BR2_arm
> +	depends on BR2_ARM_FPU_NEON || BR2_ARM_FPU_NEON_VFPV4

Hum, why BR2_ARM_CPU_HAS_NEON isn't sufficient here? I believe you can
very well have a root filesystem that is generally built with
BR2_ARM_FPU_VFPV4 (i.e the default FPU used is VFPv4), but still build
some software packages to use Neon instructions, as long as
BR2_ARM_CPU_HAS_NEON is defined.

> +	depends on BR2_ARM_INSTRUCTIONS_THUMB || BR2_ARM_INSTRUCTIONS_THUMB2

Same thing here: nothing prevents you from building your root
filesystem with full ARM instructions (i.e
BR2_ARM_INSTRUCTIONS_ARM_CHOICE), but still build some software
packages to use Thumb2 instructions, as long as BR2_ARM_CPU_HAS_THUMB2
is defined.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-04-13  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13  8:33 [Buildroot] [PATCH v2] ne10: bump version to 1.0.0 Baruch Siach
2014-04-13  8:38 ` Baruch Siach
2014-04-13  8:54 ` Thomas Petazzoni [this message]
2014-04-13  9:55   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140413105415.34ee1b19@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox