[Buildroot] [PATCH] vlc: select libvorbis when opus is also selected

[Buildroot] [PATCH] vlc: select libvorbis when opus is also selected

[Vicente Olivert Riera]

If BR2_PACKAGE_OPUS is selected then vlc will be built with support for
opus passing "--enable-opus" option to the configure script. But when
the configure script checks for the opus library it also checks for the
ogg library at the same time, so if only opus has been installed and not
ogg, then it will fail with an error message like this one:

checking for OPUS... no
configure: error: Library ogg opus needed for opus was not found

Fixes:
   http://autobuild.buildroot.net/results/4da/4da8e7cfb35c351e5d623835118512248d331d16/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/vlc/Config.in |    1 +
 package/vlc/vlc.mk    |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/vlc/Config.in b/package/vlc/Config.in
index b7c6088..cdb0d16 100644
--- a/package/vlc/Config.in
+++ b/package/vlc/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_VLC
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_LIBVORBIS if BR2_PACKAGE_OPUS
 	help
 	  VLC is a free and open source cross-platform multimedia player
 	  and framework that plays most multimedia files as well as DVD,
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index a9ee620..bcb592c 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -127,7 +127,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_OPUS),y)
 VLC_CONF_OPT += --enable-opus
-VLC_DEPENDENCIES += opus
+VLC_DEPENDENCIES += libvorbis opus
 else
 VLC_CONF_OPT += --disable-opus
 endif
-- 
1.7.1

[Buildroot] [PATCH] vlc: select libvorbis when opus is also selected

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Mon, 14 Apr 2014 15:20:07 +0100, Vicente Olivert Riera wrote:
> If BR2_PACKAGE_OPUS is selected then vlc will be built with support for
> opus passing "--enable-opus" option to the configure script. But when
> the configure script checks for the opus library it also checks for the
> ogg library at the same time, so if only opus has been installed and not
> ogg, then it will fail with an error message like this one:
> 
> checking for OPUS... no
> configure: error: Library ogg opus needed for opus was not found
> 
> Fixes:
>    http://autobuild.buildroot.net/results/4da/4da8e7cfb35c351e5d623835118512248d331d16/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/vlc/Config.in |    1 +
>  package/vlc/vlc.mk    |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com