[Buildroot] [PATCH 03/13] package/mesa3d: fix improper dependency of blind option

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Yann E. MORIN,

On Sat,  5 Apr 2014 14:10:07 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Currently, the blind option BR2_PACKAGE_MESA3D_DRI_DRIVER depends
> on !STATIC.
> 
> But this option is also selected by the various DRI drivers, and
> none of them currently depend on !STATIC (although there is a comment
> stating DRI drivers need !STATIC, there's nothing to enforce that).
> 
> So, we could well end-up with an inconsistent configuration, where some
> DRI drivers are selected even though STATIC is set.
> 
> Enclose all DRI drivers in an 'if !STATIC' condition, remove the
> dependency from the blind option, move the comment so it is nearer
> the affected drivers, rephrase the comment to match the rules about
> dependencies on toolchain features.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Bernd Kuhls <berndkuhls@hotmail.com>
> ---
>  package/mesa3d/Config.in | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Thanks, applied, with one minor nit, see below.


> +comment "DRI drivers need dynamic library"
> +	depends on BR2_PREFER_STATIC_LIB

This is not the correct wording according to the manual, it should have
been:

comment "DRI drivers need a toolchain w/ dynamic library"

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com