* [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support
@ 2014-04-18 22:30 Davide Viti
2014-04-19 17:00 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Davide Viti @ 2014-04-18 22:30 UTC (permalink / raw)
To: buildroot
From: Davide Viti <d.viti@infosolution.it>
Signed-off-by: Davide Viti <d.viti@infosolution.it>
---
package/apr/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/apr/Config.in b/package/apr/Config.in
index e06d254..73a4482 100644
--- a/package/apr/Config.in
+++ b/package/apr/Config.in
@@ -9,3 +9,7 @@ config BR2_PACKAGE_APR
consistent interface to underlying platform-specific implementations
http://apr.apache.org/
+
+comment "apr needs a toolchain w/ dynamic library"
+ depends on !BR2_USE_MMU
+ depends on BR2_PREFER_STATIC_LIB
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support
2014-04-18 22:30 [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support Davide Viti
@ 2014-04-19 17:00 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-04-19 17:00 UTC (permalink / raw)
To: buildroot
Dear Davide Viti,
On Sat, 19 Apr 2014 00:30:14 +0200, Davide Viti wrote:
> From: Davide Viti <d.viti@infosolution.it>
>
> Signed-off-by: Davide Viti <d.viti@infosolution.it>
> ---
> package/apr/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks, but I had to fix something:
> diff --git a/package/apr/Config.in b/package/apr/Config.in
> index e06d254..73a4482 100644
> --- a/package/apr/Config.in
> +++ b/package/apr/Config.in
> @@ -9,3 +9,7 @@ config BR2_PACKAGE_APR
> consistent interface to underlying platform-specific implementations
>
> http://apr.apache.org/
> +
> +comment "apr needs a toolchain w/ dynamic library"
> + depends on !BR2_USE_MMU
This should have been "depends on BR2_USE_MMU". The apr package is only
available on architectures having an MMU. So there's no point in
displaying the comment if we're on an MMU-less platform.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-19 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-18 22:30 [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support Davide Viti
2014-04-19 17:00 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox