[Buildroot] [PATCH 1/1] uboot: build custom target if custom target selected

[Buildroot] [PATCH 1/1] uboot: build custom target if custom target selected

[Laurent Cans]

When selecting custom uboot target the installation fail due to incorrect
target built. So when configuring custom uboot target, build the target
configured in buildroot configuration instead of legacy one.

Signed-off-by: Laurent Cans <laurent.cans@gmail.com>
---
 boot/uboot/uboot.mk |    1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 2174584..3e16b7a 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -51,6 +51,7 @@ UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 UBOOT_DEPENDENCIES += host-elftosb
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
 UBOOT_BIN          = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
+UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 else
 UBOOT_BIN          = u-boot.bin
 UBOOT_BIN_IFT      = $(UBOOT_BIN).ift
-- 
1.7.10.4

[Buildroot] [PATCH 1/1] uboot: build custom target if custom target selected

[Arnout Vandecappelle]

On 17/02/14 23:32, Laurent Cans wrote:
> When selecting custom uboot target the installation fail due to incorrect
> target built. So when configuring custom uboot target, build the target
> configured in buildroot configuration instead of legacy one.

 The problem is that this doesn't always work - sometimes the file you
want to use as the image is built as a side-effect of the default target
- this is e.g. the case for the SPL.

 So perhaps the solution is to add another config option to set the make
target.

 Regards,
 Arnout

> 
> Signed-off-by: Laurent Cans <laurent.cans@gmail.com>
> ---
>  boot/uboot/uboot.mk |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 2174584..3e16b7a 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -51,6 +51,7 @@ UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
>  UBOOT_DEPENDENCIES += host-elftosb
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
>  UBOOT_BIN          = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
> +UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
>  else
>  UBOOT_BIN          = u-boot.bin
>  UBOOT_BIN_IFT      = $(UBOOT_BIN).ift
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 1/1] uboot: build custom target if custom target selected

[Thomas Petazzoni]

Dear Laurent Cans,

On Mon, 17 Feb 2014 23:32:49 +0100, Laurent Cans wrote:
> When selecting custom uboot target the installation fail due to incorrect
> target built. So when configuring custom uboot target, build the target
> configured in buildroot configuration instead of legacy one.
> 
> Signed-off-by: Laurent Cans <laurent.cans@gmail.com>
> ---
>  boot/uboot/uboot.mk |    1 +
>  1 file changed, 1 insertion(+)

Two months ago you submitted this patch, and on the day of its
submission, Arnout made some comments on it. However, you never came
back with an updated version of the patch, and nobody else has stepped
up to fix the problem.

Could you resend an updated version that takes into account Arnout's
comment?

In the mean time, I'll mark your patch as "Changes requested" in our
patchwork. This means we will no longer see it in the list of pending
patches, so if you don't come back to us with an updated version, this
change will never be applied.

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com