From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt5declarative: Reduce dependencies to GLes2 only
Date: Sun, 20 Apr 2014 11:18:43 +0200 [thread overview]
Message-ID: <20140420111843.340cb627@skate> (raw)
In-Reply-To: <1396368972-8690-2-git-send-email-jezz@sysmic.org>
Fatih,
Since you are our Qt5 expert, could you comment on this patch, and give
your Reviewed-by, Tested-by and/or Acked-by?
Thanks!
Thomas
On Tue, 1 Apr 2014 18:16:11 +0200, J?r?me Pouiller wrote:
> From: J?r?me Pouiller <j.pouiller@sysmic.fr>
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
> package/qt5/qt5base/qt5base.mk | 12 +++++++++---
> package/qt5/qt5declarative/Config.in | 1 -
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 618251e..b99733a 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -96,9 +96,15 @@ else
> QT5BASE_CONFIGURE_OPTS += -no-xcb
> endif
>
> -ifeq ($(BR2_PACKAGE_QT5BASE_EGLFS),y)
> -QT5BASE_CONFIGURE_OPTS += -opengl es2 -eglfs
> +ifeq ($(BR2_PACKAGE_HAS_OPENGL_EGL)$(BR2_PACKAGE_HAS_OPENGL_ES),yy)
> +QT5BASE_CONFIGURE_OPTS += -opengl es2
> QT5BASE_DEPENDENCIES += libgles libegl
> +else
> +QT5BASE_CONFIGURE_OPTS += -no-opengl
> +endif
> +
> +ifeq ($(BR2_PACKAGE_QT5BASE_EGLFS),y)
> +QT5BASE_CONFIGURE_OPTS += -eglfs
> ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y)
> QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
> $(@D)/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp
> @@ -108,7 +114,7 @@ QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
> $(@D)/mkspecs/devices/linux-rasp-pi-g++/qeglfshooks_pi.cpp
> endif
> else
> -QT5BASE_CONFIGURE_OPTS += -no-opengl -no-eglfs
> +QT5BASE_CONFIGURE_OPTS += -no-eglfs
> endif
>
> QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl)
> diff --git a/package/qt5/qt5declarative/Config.in b/package/qt5/qt5declarative/Config.in
> index c5753b1..7f25999 100644
> --- a/package/qt5/qt5declarative/Config.in
> +++ b/package/qt5/qt5declarative/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_QT5DECLARATIVE
> select BR2_PACKAGE_QT5XMLPATTERNS
> select BR2_PACKAGE_QT5BASE
> select BR2_PACKAGE_QT5BASE_GUI
> - select BR2_PACKAGE_QT5BASE_EGLFS
> depends on BR2_PACKAGE_HAS_OPENGL_EGL
> depends on BR2_PACKAGE_HAS_OPENGL_ES
> depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-20 9:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 13:47 [Buildroot] qt5, eglfs and xcb Marco Trapanese
2014-03-30 15:21 ` Thomas Petazzoni
2014-04-01 10:05 ` Marco Trapanese
2014-04-01 12:40 ` Thomas Petazzoni
2014-04-01 16:16 ` Jérôme Pouiller
2014-04-01 16:16 ` [Buildroot] [PATCH 1/2] qt5declarative: Reduce dependencies to GLes2 only Jérôme Pouiller
2014-04-20 9:18 ` Thomas Petazzoni [this message]
2014-07-15 8:26 ` Hadrien Boutteville
2014-07-15 14:03 ` Fatih Aşıcı
2014-07-15 16:24 ` Jérôme Pouiller
2014-07-15 17:03 ` Thomas Petazzoni
2014-04-01 16:16 ` [Buildroot] [PATCH 2/2] Add supporit for Vivante xdriver Jérôme Pouiller
2014-04-20 10:13 ` Thomas Petazzoni
2014-09-16 14:46 ` Thomas Petazzoni
2014-09-16 17:07 ` Jérôme Pouiller
2014-09-16 17:59 ` Thomas Petazzoni
2014-04-01 16:18 ` [Buildroot] qt5, eglfs and xcb Marco Trapanese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420111843.340cb627@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox