Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: add toolchain dependency
@ 2014-04-18 13:07 Fabio Porcedda
  2014-04-18 13:07 ` [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: " Fabio Porcedda
  2014-04-20 15:41 ` [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: " Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Porcedda @ 2014-04-18 13:07 UTC (permalink / raw)
  To: buildroot

The "toolchain-eclipse-register" target needs the toolchain so add
toolchain as a dependency.
This also fix the support to top-level parallel make.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 42adf7c..53282ae 100644
--- a/Makefile
+++ b/Makefile
@@ -621,7 +621,7 @@ target-post-image: $(TARGETS_ROOTFS) target-finalize
 		$(call MESSAGE,"Executing post-image script $(s)"); \
 		$(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
 
-toolchain-eclipse-register:
+toolchain-eclipse-register: toolchain
 	./support/scripts/eclipse-register-toolchain `readlink -f $(O)` $(notdir $(TARGET_CROSS)) $(BR2_ARCH)
 
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
-- 
1.9.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: add toolchain dependency
  2014-04-18 13:07 [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: add toolchain dependency Fabio Porcedda
@ 2014-04-18 13:07 ` Fabio Porcedda
  2014-04-18 13:20   ` Fabio Porcedda
  2014-04-20 15:41 ` [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: " Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Porcedda @ 2014-04-18 13:07 UTC (permalink / raw)
  To: buildroot

The target depends on the toolchain so add it as a dependency.
This also fix the support to top-level parallel make.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 53282ae..e204038 100644
--- a/Makefile
+++ b/Makefile
@@ -598,7 +598,7 @@ ifneq ($(GENERATE_LOCALE),)
 # data comes preferably from the toolchain, or if the toolchain does
 # not have them (Linaro toolchains), we use the ones available on the
 # host machine.
-target-generatelocales: host-localedef
+target-generatelocales: host-localedef toolchain
 	$(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
 	$(Q)for locale in $(GENERATE_LOCALE) ; do \
 		inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
-- 
1.9.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: add toolchain dependency
  2014-04-18 13:07 ` [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: " Fabio Porcedda
@ 2014-04-18 13:20   ` Fabio Porcedda
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Porcedda @ 2014-04-18 13:20 UTC (permalink / raw)
  To: buildroot

On Fri, Apr 18, 2014 at 3:07 PM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> The target depends on the toolchain so add it as a dependency.
> This also fix the support to top-level parallel make.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 53282ae..e204038 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -598,7 +598,7 @@ ifneq ($(GENERATE_LOCALE),)
>  # data comes preferably from the toolchain, or if the toolchain does
>  # not have them (Linaro toolchains), we use the ones available on the
>  # host machine.
> -target-generatelocales: host-localedef
> +target-generatelocales: host-localedef toolchain
>         $(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
>         $(Q)for locale in $(GENERATE_LOCALE) ; do \
>                 inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
> --
> 1.9.2
>

I've done like that because i think that the "target-generatelocales"
depends only on the toolchain target, doesn't it?

Regards
-- 
Fabio Porcedda

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: add toolchain dependency
  2014-04-18 13:07 [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: add toolchain dependency Fabio Porcedda
  2014-04-18 13:07 ` [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: " Fabio Porcedda
@ 2014-04-20 15:41 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2014-04-20 15:41 UTC (permalink / raw)
  To: buildroot

Dear Fabio Porcedda,

On Fri, 18 Apr 2014 15:07:31 +0200, Fabio Porcedda wrote:
> The "toolchain-eclipse-register" target needs the toolchain so add
> toolchain as a dependency.
> This also fix the support to top-level parallel make.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-04-20 15:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-18 13:07 [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: add toolchain dependency Fabio Porcedda
2014-04-18 13:07 ` [Buildroot] [PATCH 2/2] Makefile: target-generatelocales: " Fabio Porcedda
2014-04-18 13:20   ` Fabio Porcedda
2014-04-20 15:41 ` [Buildroot] [PATCH 1/2] Makefile: toolchain-eclipse-register: " Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox