[Buildroot] [PATCH] smack: needs kernel headers v3.0+

[Buildroot] [PATCH] smack: needs kernel headers v3.0+

[Baruch Siach]

smack uses symbols that are exported to userspace only since Linux kernel
commit 1dbe39424a43 (xattr.h: expose string defines to userspace).

Fixes:
http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/smack/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/smack/Config.in b/package/smack/Config.in
index 618a6807e175..55e9d2e694c3 100644
--- a/package/smack/Config.in
+++ b/package/smack/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_SMACK
 	bool "smack"
 	depends on !BR2_PREFER_STATIC_LIB # dlfcn.h
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
 	help
 	  User space programs and libraries for SMACK.
 
@@ -28,5 +29,6 @@ config BR2_PACKAGE_SMACK
 
 	  https://github.com/smack-team/smack
 
-comment "smack needs a toolchain w/ dynamic library"
+comment "smack needs a toolchain w/ dynamic library, headers >= 3.0"
 	depends on BR2_PREFER_STATIC_LIB
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
-- 
1.9.2

[Buildroot] [PATCH] smack: needs kernel headers v3.0+

[Thomas Petazzoni]

Dear Baruch Siach,

On Thu, 24 Apr 2014 11:56:19 +0300, Baruch Siach wrote:
> smack uses symbols that are exported to userspace only since Linux kernel
> commit 1dbe39424a43 (xattr.h: expose string defines to userspace).
> 
> Fixes:
> http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/smack/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied... but I just realized there was a mistake:

> -comment "smack needs a toolchain w/ dynamic library"
> +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0"
>  	depends on BR2_PREFER_STATIC_LIB
> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0

This means the comment will only be displayed if both conditions are
met (i.e static lib is enabled *and* we don't have at least 3.0 kernel
headers). But we need the comment to be displayed if static lib is
enabled *OR* we don't have at least 3.0 kernel headers.

Could you send a followup patch to fix this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] smack: needs kernel headers v3.0+

[Baruch Siach]

Hi Thomas,

On Thu, Apr 24, 2014 at 11:12:42AM +0200, Thomas Petazzoni wrote:
> On Thu, 24 Apr 2014 11:56:19 +0300, Baruch Siach wrote:
> > smack uses symbols that are exported to userspace only since Linux kernel
> > commit 1dbe39424a43 (xattr.h: expose string defines to userspace).
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/smack/Config.in | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Applied... but I just realized there was a mistake:
> 
> > -comment "smack needs a toolchain w/ dynamic library"
> > +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0"
> >  	depends on BR2_PREFER_STATIC_LIB
> > +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> 
> This means the comment will only be displayed if both conditions are
> met (i.e static lib is enabled *and* we don't have at least 3.0 kernel
> headers). But we need the comment to be displayed if static lib is
> enabled *OR* we don't have at least 3.0 kernel headers.
> 
> Could you send a followup patch to fix this?

Will send a fix shortly. Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -