[Buildroot] [PATCH v2 1/1] xlib_libXpm: needs MMU (fork)

[Buildroot] [PATCH v2 1/1] xlib_libXpm: needs MMU (fork)

[Bernd Kuhls]

Fixes http://autobuild.buildroot.net/results/c57/c571b0a9d9f36a445ea36a4bd609154f9a9bddd5/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: extend patch to reverse dependency of xlib_libXpm (Thomas)

 package/x11r7/xlib_libXaw/Config.in |    1 +
 package/x11r7/xlib_libXpm/Config.in |    1 +
 2 files changed, 2 insertions(+)

diff --git a/package/x11r7/xlib_libXaw/Config.in b/package/x11r7/xlib_libXaw/Config.in
index 3695bb6..12addc4 100644
--- a/package/x11r7/xlib_libXaw/Config.in
+++ b/package/x11r7/xlib_libXaw/Config.in
@@ -5,5 +5,6 @@ config BR2_PACKAGE_XLIB_LIBXAW
 	select BR2_PACKAGE_XLIB_LIBXMU
 	select BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork() / xlib_libXpm
 	help
 	  X.Org Xaw library
diff --git a/package/x11r7/xlib_libXpm/Config.in b/package/x11r7/xlib_libXpm/Config.in
index 528498c..077041a 100644
--- a/package/x11r7/xlib_libXpm/Config.in
+++ b/package/x11r7/xlib_libXpm/Config.in
@@ -4,5 +4,6 @@ config BR2_PACKAGE_XLIB_LIBXPM
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XPROTO_XPROTO
+	depends on BR2_USE_MMU # fork()
 	help
 	  X.Org Xpm library
-- 
1.7.10.4

[Buildroot] [PATCH v2 1/1] xlib_libXpm: needs MMU (fork)

[Baruch Siach]

Hi Bernd,

On Tue, Apr 29, 2014 at 09:37:36PM +0200, Bernd Kuhls wrote:
> Fixes http://autobuild.buildroot.net/results/c57/c571b0a9d9f36a445ea36a4bd609154f9a9bddd5/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: extend patch to reverse dependency of xlib_libXpm (Thomas)

The xvkbd package also selects BR2_PACKAGE_XLIB_LIBXPM.

> 
>  package/x11r7/xlib_libXaw/Config.in |    1 +
>  package/x11r7/xlib_libXpm/Config.in |    1 +
>  2 files changed, 2 insertions(+)

> diff --git a/package/x11r7/xlib_libXaw/Config.in 
> b/package/x11r7/xlib_libXaw/Config.in
> index 3695bb6..12addc4 100644
> --- a/package/x11r7/xlib_libXaw/Config.in
> +++ b/package/x11r7/xlib_libXaw/Config.in
> @@ -5,5 +5,6 @@ config BR2_PACKAGE_XLIB_LIBXAW
>  	select BR2_PACKAGE_XLIB_LIBXMU
>  	select BR2_PACKAGE_XLIB_LIBXPM
>  	select BR2_PACKAGE_XPROTO_XPROTO
> +	depends on BR2_USE_MMU # fork() / xlib_libXpm

This dependency should be propagated further recursively. Many packages select 
BR2_PACKAGE_XLIB_LIBXAW and all of them must also depend on BR2_USE_MMU.

>  	help
>  	  X.Org Xaw library
> diff --git a/package/x11r7/xlib_libXpm/Config.in b/package/x11r7/xlib_libXpm/Config.in
> index 528498c..077041a 100644
> --- a/package/x11r7/xlib_libXpm/Config.in
> +++ b/package/x11r7/xlib_libXpm/Config.in
> @@ -4,5 +4,6 @@ config BR2_PACKAGE_XLIB_LIBXPM
>  	select BR2_PACKAGE_XLIB_LIBXEXT
>  	select BR2_PACKAGE_XLIB_LIBXT
>  	select BR2_PACKAGE_XPROTO_XPROTO
> +	depends on BR2_USE_MMU # fork()
>  	help
>  	  X.Org Xpm library
> -- 

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH v2 1/1] xlib_libXpm: needs MMU (fork)

[Thomas Petazzoni]

Dear Baruch Siach,

On Tue, 29 Apr 2014 23:07:22 +0300, Baruch Siach wrote:

> This dependency should be propagated further recursively. Many packages select 
> BR2_PACKAGE_XLIB_LIBXAW and all of them must also depend on BR2_USE_MMU.

Maybe we should take a step back and see if libXpm could be fixed to
not use fork() at all, or use vfork().

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com