Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
@ 2014-05-03 16:33 Yann E. MORIN
  2014-05-03 19:03 ` Peter Korsgaard
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-05-03 16:33 UTC (permalink / raw)
  To: buildroot

From: Samuel Martin <s.martin49@gmail.com>

zeromp's configure script correctly detects the fork availability, but
unconditionally build test_fork program whatever the fork() availability.

This patch fixes the build-system by disabling test_fork when fork is
not available (e.g. when !BR2_USEMMU).

Fixes:
  http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
[yann.morin.1998 at free.fr: remove Makefile.in hunks]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
 a i686 target]
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++
 package/zeromq/zeromq.mk                           |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch

diff --git a/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
new file mode 100644
index 0000000..1eefdc3
--- /dev/null
+++ b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
@@ -0,0 +1,52 @@
+From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001
+From: Samuel Martin <s.martin49@gmail.com>
+Date: Sat, 3 May 2014 12:22:38 +0200
+Subject: [PATCH] tests: disable test_fork if fork() is not available
+
+Signed-off-by: Samuel Martin <s.martin49@gmail.com>
+---
+ configure.ac      | 1 +
+ tests/Makefile.am | 8 ++++++--
+ tests/Makefile.in | 8 ++++----
+ 3 files changed, 11 insertions(+), 6 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 0c41604..8f8521c 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -431,6 +431,7 @@ AM_CONDITIONAL(BUILD_PGM, test "x$libzmq_pgm_ext" = "xyes")
+ AM_CONDITIONAL(ON_MINGW, test "x$libzmq_on_mingw32" = "xyes")
+ AM_CONDITIONAL(ON_ANDROID, test "x$libzmq_on_android" = "xyes")
+ AM_CONDITIONAL(ON_LINUX, test "x$libzmq_on_linux" = "xyes")
++AM_CONDITIONAL(HAVE_FORK, test "x$ac_cv_func_fork" = "xyes")
+ 
+ # Checks for library functions.
+ AC_TYPE_SIGNAL
+diff --git a/tests/Makefile.am b/tests/Makefile.am
+index 0cfe4e8..2a1e257 100644
+--- a/tests/Makefile.am
++++ b/tests/Makefile.am
+@@ -46,8 +46,10 @@ if !ON_MINGW
+ noinst_PROGRAMS += test_shutdown_stress \
+                    test_pair_ipc \
+                    test_reqrep_ipc \
+-                   test_timeo \
+-                   test_fork
++                   test_timeo
++if HAVE_FORK
++noinst_PROGRAMS += test_fork
++endif
+ endif
+ 
+ test_system_SOURCES = test_system.cpp
+@@ -93,8 +95,10 @@ test_shutdown_stress_SOURCES = test_shutdown_stress.cpp
+ test_pair_ipc_SOURCES = test_pair_ipc.cpp testutil.hpp
+ test_reqrep_ipc_SOURCES = test_reqrep_ipc.cpp testutil.hpp
+ test_timeo_SOURCES = test_timeo.cpp
++if HAVE_FORK
+ test_fork_SOURCES = test_fork.cpp
+ endif
++endif
+ 
+ #  Run the test cases
+ TESTS = $(noinst_PROGRAMS)
diff --git a/package/zeromq/zeromq.mk b/package/zeromq/zeromq.mk
index 833c1d3..7802916 100644
--- a/package/zeromq/zeromq.mk
+++ b/package/zeromq/zeromq.mk
@@ -10,6 +10,7 @@ ZEROMQ_INSTALL_STAGING = YES
 ZEROMQ_DEPENDENCIES = util-linux
 ZEROMQ_LICENSE = LGPLv3+ with exceptions
 ZEROMQ_LICENSE_FILES = COPYING COPYING.LESSER
+ZEROMQ_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_ZEROMQ_PGM),y)
 	ZEROMQ_DEPENDENCIES += host-pkgconf openpgm
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
  2014-05-03 16:33 [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available Yann E. MORIN
@ 2014-05-03 19:03 ` Peter Korsgaard
  2014-05-03 19:52   ` Samuel Martin
  2014-05-09  9:47 ` Jerzy Grzegorek
       [not found] ` <536CA383.404@trzebnica.net>
  2 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2014-05-03 19:03 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: Samuel Martin <s.martin49@gmail.com>
 > zeromp's configure script correctly detects the fork availability, but
 > unconditionally build test_fork program whatever the fork() availability.

 > This patch fixes the build-system by disabling test_fork when fork is
 > not available (e.g. when !BR2_USEMMU).

The symbol is called BR2_USE_MMU.

Committed, thanks. Please don't forget to send the patch upstream.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
  2014-05-03 19:03 ` Peter Korsgaard
@ 2014-05-03 19:52   ` Samuel Martin
  0 siblings, 0 replies; 6+ messages in thread
From: Samuel Martin @ 2014-05-03 19:52 UTC (permalink / raw)
  To: buildroot

Peter, all,

On Sat, May 3, 2014 at 9:03 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
>  > From: Samuel Martin <s.martin49@gmail.com>
>  > zeromp's configure script correctly detects the fork availability, but
>  > unconditionally build test_fork program whatever the fork() availability.
>
>  > This patch fixes the build-system by disabling test_fork when fork is
>  > not available (e.g. when !BR2_USEMMU).
>
> The symbol is called BR2_USE_MMU.
>
> Committed, thanks. Please don't forget to send the patch upstream.
Already on it! :)

>
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



-- 
Samuel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
  2014-05-03 16:33 [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available Yann E. MORIN
  2014-05-03 19:03 ` Peter Korsgaard
@ 2014-05-09  9:47 ` Jerzy Grzegorek
       [not found] ` <536CA383.404@trzebnica.net>
  2 siblings, 0 replies; 6+ messages in thread
From: Jerzy Grzegorek @ 2014-05-09  9:47 UTC (permalink / raw)
  To: buildroot


Hi Yann,

> From: Samuel Martin <s.martin49@gmail.com>
>
> zeromp's configure script correctly detects the fork availability, but
> unconditionally build test_fork program whatever the fork() availability.
>
> This patch fixes the build-system by disabling test_fork when fork is
> not available (e.g. when !BR2_USEMMU).
>
> Fixes:
>    http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> [yann.morin.1998 at free.fr: remove Makefile.in hunks]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> [yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
>   a i686 target]
> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>   ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++
>   package/zeromq/zeromq.mk                           |  1 +
>   2 files changed, 53 insertions(+)
>   create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
>
> diff --git a/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> new file mode 100644
> index 0000000..1eefdc3
> --- /dev/null
> +++ b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> @@ -0,0 +1,52 @@
> +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001
> +From: Samuel Martin <s.martin49@gmail.com>
> +Date: Sat, 3 May 2014 12:22:38 +0200
> +Subject: [PATCH] tests: disable test_fork if fork() is not available
> +
> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> +---
> + configure.ac      | 1 +
> + tests/Makefile.am | 8 ++++++--
> + tests/Makefile.in | 8 ++++----

What about the changes in Makefile.in file?
I don't see them here.

Regards,
Jerzy

> + 3 files changed, 11 insertions(+), 6 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 0c41604..8f8521c 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -431,6 +431,7 @@ AM_CONDITIONAL(BUILD_PGM, test "x$libzmq_pgm_ext" = "xyes")
> + AM_CONDITIONAL(ON_MINGW, test "x$libzmq_on_mingw32" = "xyes")
> + AM_CONDITIONAL(ON_ANDROID, test "x$libzmq_on_android" = "xyes")
> + AM_CONDITIONAL(ON_LINUX, test "x$libzmq_on_linux" = "xyes")
> ++AM_CONDITIONAL(HAVE_FORK, test "x$ac_cv_func_fork" = "xyes")
> +
> + # Checks for library functions.
> + AC_TYPE_SIGNAL
> +diff --git a/tests/Makefile.am b/tests/Makefile.am
> +index 0cfe4e8..2a1e257 100644
> +--- a/tests/Makefile.am
> ++++ b/tests/Makefile.am
> +@@ -46,8 +46,10 @@ if !ON_MINGW
> + noinst_PROGRAMS += test_shutdown_stress \
> +                    test_pair_ipc \
> +                    test_reqrep_ipc \
> +-                   test_timeo \
> +-                   test_fork
> ++                   test_timeo
> ++if HAVE_FORK
> ++noinst_PROGRAMS += test_fork
> ++endif
> + endif
> +
> + test_system_SOURCES = test_system.cpp
> +@@ -93,8 +95,10 @@ test_shutdown_stress_SOURCES = test_shutdown_stress.cpp
> + test_pair_ipc_SOURCES = test_pair_ipc.cpp testutil.hpp
> + test_reqrep_ipc_SOURCES = test_reqrep_ipc.cpp testutil.hpp
> + test_timeo_SOURCES = test_timeo.cpp
> ++if HAVE_FORK
> + test_fork_SOURCES = test_fork.cpp
> + endif
> ++endif
> +
> + #  Run the test cases
> + TESTS = $(noinst_PROGRAMS)
> diff --git a/package/zeromq/zeromq.mk b/package/zeromq/zeromq.mk
> index 833c1d3..7802916 100644
> --- a/package/zeromq/zeromq.mk
> +++ b/package/zeromq/zeromq.mk
> @@ -10,6 +10,7 @@ ZEROMQ_INSTALL_STAGING = YES
>   ZEROMQ_DEPENDENCIES = util-linux
>   ZEROMQ_LICENSE = LGPLv3+ with exceptions
>   ZEROMQ_LICENSE_FILES = COPYING COPYING.LESSER
> +ZEROMQ_AUTORECONF = YES
>   
>   ifeq ($(BR2_PACKAGE_ZEROMQ_PGM),y)
>   	ZEROMQ_DEPENDENCIES += host-pkgconf openpgm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
       [not found] ` <536CA383.404@trzebnica.net>
@ 2014-05-09 10:21   ` Yann E. MORIN
       [not found]   ` <20140509094736.GA3173@free.fr>
  1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-05-09 10:21 UTC (permalink / raw)
  To: buildroot

Jerzy, All,

[forgot to cc the Buildroot list on previous mail, sorry]

On 2014-05-09 11:44 +0200, Jerzy Grzegorek spake thusly:
> >From: Samuel Martin <s.martin49@gmail.com>
> >
> >zeromp's configure script correctly detects the fork availability, but
> >unconditionally build test_fork program whatever the fork() availability.
> >
> >This patch fixes the build-system by disabling test_fork when fork is
> >not available (e.g. when !BR2_USEMMU).
> >
> >Fixes:
> >   http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/
> >
> >Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> >[yann.morin.1998 at free.fr: remove Makefile.in hunks]
> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >[yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
> >  a i686 target]
> >Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >---
> >  ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++
> >  package/zeromq/zeromq.mk                           |  1 +
> >  2 files changed, 53 insertions(+)
> >  create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >
> >diff --git a/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >new file mode 100644
> >index 0000000..1eefdc3
> >--- /dev/null
> >+++ b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
> >@@ -0,0 +1,52 @@
> >+From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001
> >+From: Samuel Martin <s.martin49@gmail.com>
> >+Date: Sat, 3 May 2014 12:22:38 +0200
> >+Subject: [PATCH] tests: disable test_fork if fork() is not available
> >+
> >+Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> >+---
> >+ configure.ac      | 1 +
> >+ tests/Makefile.am | 8 ++++++--
> >+ tests/Makefile.in | 8 ++++----
> 
> What about the changes in Makefile.in file?
> I don't see them here.

Ah, right. When I edited the patch to remove them, I forgot to remove
Makefile.in from the diffstat. We do not need the changes to Makefile.in
in this patch, since we do autoreconf the beast, so Makefile.in gets
re-generated.

See the commit log that states;
    [yann.morin.1998 at free.fr: remove Makefile.in hunks]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available
       [not found]   ` <20140509094736.GA3173@free.fr>
@ 2014-05-09 10:42     ` Jerzy Grzegorek
  0 siblings, 0 replies; 6+ messages in thread
From: Jerzy Grzegorek @ 2014-05-09 10:42 UTC (permalink / raw)
  To: buildroot


Hi Yann,

> Jerzy, All,
>
> On 2014-05-09 11:44 +0200, Jerzy Grzegorek spake thusly:
>>> From: Samuel Martin <s.martin49@gmail.com>
>>>
>>> zeromp's configure script correctly detects the fork availability, but
>>> unconditionally build test_fork program whatever the fork() availability.
>>>
>>> This patch fixes the build-system by disabling test_fork when fork is
>>> not available (e.g. when !BR2_USEMMU).
>>>
>>> Fixes:
>>>    http://autobuild.buildroot.org/results/359/3599cc3b7bf2bb22a78961cd84d21cb03cbd7015/
>>>
>>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>>> [yann.morin.1998 at free.fr: remove Makefile.in hunks]
>>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>> [yann.morin.1998 at free.fr: tested against the failed bfin config, as well as
>>>   a i686 target]
>>> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>> ---
>>>   ...isable-test_fork-if-fork-is-not-available.patch | 52 ++++++++++++++++++++++
>>>   package/zeromq/zeromq.mk                           |  1 +
>>>   2 files changed, 53 insertions(+)
>>>   create mode 100644 package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
>>>
>>> diff --git a/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
>>> new file mode 100644
>>> index 0000000..1eefdc3
>>> --- /dev/null
>>> +++ b/package/zeromq/zeromq-0001-tests-disable-test_fork-if-fork-is-not-available.patch
>>> @@ -0,0 +1,52 @@
>>> +From b50912f2eecec1ea7accc155f8132116f8702075 Mon Sep 17 00:00:00 2001
>>> +From: Samuel Martin <s.martin49@gmail.com>
>>> +Date: Sat, 3 May 2014 12:22:38 +0200
>>> +Subject: [PATCH] tests: disable test_fork if fork() is not available
>>> +
>>> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>>> +---
>>> + configure.ac      | 1 +
>>> + tests/Makefile.am | 8 ++++++--
>>> + tests/Makefile.in | 8 ++++----
>> What about the changes in Makefile.in file?
>> I don't see them here.
> Ah, right. When I edited the patch to remove them, I forgot to remove
> Makefile.in from the diffstat. We do not need the changes to Makefile.in
> in this patch, since we do autoreconf the beast, so Makefile.in gets
> re-generated.

Thanks for the clarification.

Regards,
Jerzy

>
> See the commit log that states;
>      [yann.morin.1998 at free.fr: remove Makefile.in hunks]
>
> Regards,
> Yann E. MORIN.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-05-09 10:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-03 16:33 [Buildroot] [PATCH] zeromq: disable test_fork when fork() is no available Yann E. MORIN
2014-05-03 19:03 ` Peter Korsgaard
2014-05-03 19:52   ` Samuel Martin
2014-05-09  9:47 ` Jerzy Grzegorek
     [not found] ` <536CA383.404@trzebnica.net>
2014-05-09 10:21   ` Yann E. MORIN
     [not found]   ` <20140509094736.GA3173@free.fr>
2014-05-09 10:42     ` Jerzy Grzegorek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox