* [Buildroot] [PATCH] protobuf: host-protobuf can only be built on certain architectures
@ 2014-05-12 11:10 Thomas Petazzoni
2014-05-12 11:20 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2014-05-12 11:10 UTC (permalink / raw)
To: buildroot
The host-protobuf package can only build on certain architectures. For
example, host-protobuf does not build on PowerPC platforms, causing
build failures on the autobuilders. Since we don't really care about
build platforms other than x86 and x86-64, this commit restricts the
build of host-protobuf to these architectures only, even though if
technically it could build on ARM and MIPS.
Fixes:
http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/protobuf-c/Config.in | 3 +++
package/protobuf/Config.in | 3 +++
package/python-protobuf/Config.in | 2 ++
3 files changed, 8 insertions(+)
diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
index 732befc..f9fab37 100644
--- a/package/protobuf-c/Config.in
+++ b/package/protobuf-c/Config.in
@@ -2,6 +2,8 @@ config BR2_PACKAGE_PROTOBUF_C
bool "protobuf-c"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
+ # host-protobuf only builds on certain architectures
+ depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
help
Code generator and runtime libraries to use Protocol Buffers
from pure C (not C++).
@@ -10,3 +12,4 @@ config BR2_PACKAGE_PROTOBUF_C
comment "protobuf-c needs a toolchain w/ C++, threads"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index 293a9b9..6015b13 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -5,6 +5,8 @@ config BR2_PACKAGE_PROTOBUF
# See src/google/protobuf/stubs/platform_macros.h for supported archs.
# PowerPC doesn't actually work.
depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+ # host-protobuf only builds on certain architectures
+ depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
help
Protocol buffers are Google's language-neutral, platform-neutral,
extensible mechanism for serializing structured data.
@@ -14,3 +16,4 @@ config BR2_PACKAGE_PROTOBUF
comment "protobuf needs a toolchain w/ C++, threads"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+ depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
diff --git a/package/python-protobuf/Config.in b/package/python-protobuf/Config.in
index ec22057..6649dfc 100644
--- a/package/python-protobuf/Config.in
+++ b/package/python-protobuf/Config.in
@@ -1,6 +1,8 @@
config BR2_PACKAGE_PYTHON_PROTOBUF
bool "python-protobuf"
depends on BR2_PACKAGE_PYTHON
+ # host-protobuf only builds on certain architectures
+ depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
help
Python implementation of the Google Protocol Buffers.
--
1.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] protobuf: host-protobuf can only be built on certain architectures
2014-05-12 11:10 [Buildroot] [PATCH] protobuf: host-protobuf can only be built on certain architectures Thomas Petazzoni
@ 2014-05-12 11:20 ` Baruch Siach
2014-05-12 13:11 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2014-05-12 11:20 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, May 12, 2014 at 01:10:31PM +0200, Thomas Petazzoni wrote:
> The host-protobuf package can only build on certain architectures. For
> example, host-protobuf does not build on PowerPC platforms, causing
> build failures on the autobuilders. Since we don't really care about
> build platforms other than x86 and x86-64, this commit restricts the
> build of host-protobuf to these architectures only, even though if
Redundant 'if'.
> technically it could build on ARM and MIPS.
>
> Fixes:
>
> http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
What about reverse dependencies? A quick search shows collectd (selects
BR2_PACKAGE_PROTOBUF_C), and ola (selects BR2_PACKAGE_PYTHON_PROTOBUF).
baruch
> ---
> package/protobuf-c/Config.in | 3 +++
> package/protobuf/Config.in | 3 +++
> package/python-protobuf/Config.in | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
> index 732befc..f9fab37 100644
> --- a/package/protobuf-c/Config.in
> +++ b/package/protobuf-c/Config.in
> @@ -2,6 +2,8 @@ config BR2_PACKAGE_PROTOBUF_C
> bool "protobuf-c"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
> + # host-protobuf only builds on certain architectures
> + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> help
> Code generator and runtime libraries to use Protocol Buffers
> from pure C (not C++).
> @@ -10,3 +12,4 @@ config BR2_PACKAGE_PROTOBUF_C
>
> comment "protobuf-c needs a toolchain w/ C++, threads"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
> index 293a9b9..6015b13 100644
> --- a/package/protobuf/Config.in
> +++ b/package/protobuf/Config.in
> @@ -5,6 +5,8 @@ config BR2_PACKAGE_PROTOBUF
> # See src/google/protobuf/stubs/platform_macros.h for supported archs.
> # PowerPC doesn't actually work.
> depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
> + # host-protobuf only builds on certain architectures
> + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> help
> Protocol buffers are Google's language-neutral, platform-neutral,
> extensible mechanism for serializing structured data.
> @@ -14,3 +16,4 @@ config BR2_PACKAGE_PROTOBUF
> comment "protobuf needs a toolchain w/ C++, threads"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
> + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> diff --git a/package/python-protobuf/Config.in b/package/python-protobuf/Config.in
> index ec22057..6649dfc 100644
> --- a/package/python-protobuf/Config.in
> +++ b/package/python-protobuf/Config.in
> @@ -1,6 +1,8 @@
> config BR2_PACKAGE_PYTHON_PROTOBUF
> bool "python-protobuf"
> depends on BR2_PACKAGE_PYTHON
> + # host-protobuf only builds on certain architectures
> + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> help
> Python implementation of the Google Protocol Buffers.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] protobuf: host-protobuf can only be built on certain architectures
2014-05-12 11:20 ` Baruch Siach
@ 2014-05-12 13:11 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-05-12 13:11 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Mon, 12 May 2014 14:20:44 +0300, Baruch Siach wrote:
> > technically it could build on ARM and MIPS.
> >
> > Fixes:
> >
> > http://autobuild.buildroot.org/results/9b9/9b9b20b0e4694b11425cdc2382650cdc2774e400/
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> What about reverse dependencies? A quick search shows collectd (selects
> BR2_PACKAGE_PROTOBUF_C), and ola (selects BR2_PACKAGE_PYTHON_PROTOBUF).
Aaah, indeed. I thought of all the packages using host-protobuf, but
not the reverse dependencies of those packages.
I'll resend an updated version.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 11:10 [Buildroot] [PATCH] protobuf: host-protobuf can only be built on certain architectures Thomas Petazzoni
2014-05-12 11:20 ` Baruch Siach
2014-05-12 13:11 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox