[Buildroot] [PATCH] package/avahi: does not build with static-only

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Yann E. MORIN]

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/avahi/Config.in b/package/avahi/Config.in
index fd4d229..483d976 100644
--- a/package/avahi/Config.in
+++ b/package/avahi/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_AVAHI
 	# libdaemon uses fork()
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  Avahi is a system which facilitates service
-- 
1.8.3.2

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Fri, 16 May 2014 18:11:21 +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/avahi/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Autobuilder reference?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Yann E. MORIN]

Thomas, All,

On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Fri, 16 May 2014 18:11:21 +0200, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  package/avahi/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Autobuilder reference?

Gah, I forgot to add it...

Fixes (which I reproduced here):
    http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

Should fix (which I did not even try to reproduce):
    http://autobuild.buildroot.net/results/4ef/4ef5bfc17f50bddb00f7ef3d62fc1fe963b7da82
    http://autobuild.buildroot.net/results/76e/76e4854812b0ef3862c080eead4012b35ef27f0f
    http://autobuild.buildroot.net/results/5bf/5bfb3fd9fe61bef5f998dc5999ce2060c334662c
    http://autobuild.buildroot.net/results/dc6/dc607c35471ef6dda04e06ad05ae7794615af578
    [...]

I'll respin it later with those references added...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 >> Autobuilder reference?

 > Gah, I forgot to add it...

 > Fixes (which I reproduced here):
 >     http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

 > Should fix (which I did not even try to reproduce):
 >     http://autobuild.buildroot.net/results/4ef/4ef5bfc17f50bddb00f7ef3d62fc1fe963b7da82
 >     http://autobuild.buildroot.net/results/76e/76e4854812b0ef3862c080eead4012b35ef27f0f
 >     http://autobuild.buildroot.net/results/5bf/5bfb3fd9fe61bef5f998dc5999ce2060c334662c
 >     http://autobuild.buildroot.net/results/dc6/dc607c35471ef6dda04e06ad05ae7794615af578
 >     [...]

 > I'll respin it later with those references added...

Thanks. Please also adjust the reverse dependencies (xbmc). Does this
dependency apply to all of avahi, or just the daemon?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Fri, 16 May 2014 20:49:54 +0200, Yann E. MORIN wrote:
> Thomas, All,
> 
> On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:
> > Dear Yann E. MORIN,
> > 
> > On Fri, 16 May 2014 18:11:21 +0200, Yann E. MORIN wrote:
> > > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > > 
> > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > > ---
> > >  package/avahi/Config.in | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Autobuilder reference?
> 
> Gah, I forgot to add it...
> 
> Fixes (which I reproduced here):
>     http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec

To me, it doesn't really seem like an impossibility of building Avahi
with static libraries. Shouldn't we look a little bit harder at fixing
the configure problem?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Yann E. MORIN]

Thomas, All,

On 2014-05-16 22:42 +0200, Thomas Petazzoni spake thusly:
> On Fri, 16 May 2014 20:49:54 +0200, Yann E. MORIN wrote:
> > Thomas, All,
> > 
> > On 2014-05-16 20:16 +0200, Thomas Petazzoni spake thusly:
> > > Dear Yann E. MORIN,
> > > 
> > > On Fri, 16 May 2014 18:11:21 +0200, Yann E. MORIN wrote:
> > > > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > > > 
> > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > > > ---
> > > >  package/avahi/Config.in | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > Autobuilder reference?
> > 
> > Gah, I forgot to add it...
> > 
> > Fixes (which I reproduced here):
> >     http://autobuild.buildroot.net/results/ea2/ea2c8f20c4032bf82876805ea787a55834091cec
> 
> To me, it doesn't really seem like an impossibility of building Avahi
> with static libraries. Shouldn't we look a little bit harder at fixing
> the configure problem?

The ./configure of avahi explicitly checks that it can link dynamically
with pthreads.

I'm not sure why they decided to do that, but since that's what the
configure does, and does it on purpose, I haven't even tried to see if
it was really needed. But if upstream decided (for whatever reasons)
that they want to explicitly check for that, I don't think we should try
to revert this check.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/avahi: does not build with static-only

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Fri, 16 May 2014 22:51:44 +0200, Yann E. MORIN wrote:

> > To me, it doesn't really seem like an impossibility of building Avahi
> > with static libraries. Shouldn't we look a little bit harder at fixing
> > the configure problem?
> 
> The ./configure of avahi explicitly checks that it can link dynamically
> with pthreads.
> 
> I'm not sure why they decided to do that, but since that's what the
> configure does, and does it on purpose, I haven't even tried to see if
> it was really needed. But if upstream decided (for whatever reasons)
> that they want to explicitly check for that, I don't think we should try
> to revert this check.

Ok, fair enough :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com