From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms
Date: Thu, 22 May 2014 13:10:18 +0300 [thread overview]
Message-ID: <20140522101018.GE4986@tarshish> (raw)
In-Reply-To: <1400752943-49138-1-git-send-email-Vincent.Riera@imgtec.com>
Hi Vicente,
On Thu, May 22, 2014 at 11:02:23AM +0100, Vicente Olivert Riera wrote:
> After talking with upstream we concluded that MIPS64 n32 is treated as a
> 32-bit architecture by libnss because it has 32-bit pointers, so
> USE_64=1 should not be set in that case.
>
> Upstream bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1010730
>
> WRT:
> http://git.buildroot.net/buildroot/commit/?id=73e6ae0fe6a69f88183ae33401f2314088b5f799
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/libnss/Config.in | 1 -
> package/libnss/libnss.mk | 2 +-
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/package/libnss/Config.in b/package/libnss/Config.in
> index 9a1668c..0401a67 100644
> --- a/package/libnss/Config.in
> +++ b/package/libnss/Config.in
> @@ -6,7 +6,6 @@ config BR2_PACKAGE_LIBNSS
> depends on BR2_LARGEFILE
> depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
> depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
> - depends on !BR2_MIPS_NABI32
Please update the comment dependency accordingly.
baruch
> help
> Network Security Services (NSS) is a set of libraries designed
> to support development of security-enabled client and server
> diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
> index 666df74..b07cb6f 100644
> --- a/package/libnss/libnss.mk
> +++ b/package/libnss/libnss.mk
> @@ -29,7 +29,7 @@ LIBNSS_BUILD_VARS = MOZILLA_CLIENT=1 \
> OS_RELEASE="2.6" \
> OS_TEST="$(ARCH)"
>
> -ifeq ($(BR2_ARCH_IS_64),y)
> +ifeq ($(BR2_ARCH_IS_64)$(BR2_MIPS_NABI32),yn)
> LIBNSS_BUILD_VARS += USE_64=1
> endif
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-05-22 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 10:02 [Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms Vicente Olivert Riera
2014-05-22 10:10 ` Baruch Siach [this message]
2014-05-22 10:10 ` Thomas Petazzoni
2014-05-22 10:11 ` Vicente Olivert Riera
2014-05-22 10:46 ` Thomas Petazzoni
2014-05-22 10:47 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522101018.GE4986@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox