From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms
Date: Thu, 22 May 2014 12:46:02 +0200 [thread overview]
Message-ID: <20140522124602.0df63a66@free-electrons.com> (raw)
In-Reply-To: <537DCD68.4050309@imgtec.com>
Dear Vicente Olivert Riera,
On Thu, 22 May 2014 11:11:52 +0100, Vicente Olivert Riera wrote:
> >> -ifeq ($(BR2_ARCH_IS_64),y)
> >> +ifeq ($(BR2_ARCH_IS_64)$(BR2_MIPS_NABI32),yn)
> >
> > This cannot work: when an option is disabled, its value is empty, not
> > 'n'.
> >
> > So:
> >
> > # a comment here that explains the exception for MIPS_NABI32
> > ifeq ($(BR2_ARCH_IS_64),y)
> > ifeq ($(BR2_MIPS_NABI32),)
> > ...
> > endif
> > endif
> >
> > Thanks!
> >
> > Thomas
> >
>
> I tried it and it worked.
Yes, it worked in your case, because the condition had to be false in
your case. But with your implementation, the condition will *always* be
false, so the USE_64 thing will no longer be passed for BR2_ARCH_IS_64
situations that are *not* BR2_MIPS_NABI32.
Thomsa
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-22 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 10:02 [Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms Vicente Olivert Riera
2014-05-22 10:10 ` Baruch Siach
2014-05-22 10:10 ` Thomas Petazzoni
2014-05-22 10:11 ` Vicente Olivert Riera
2014-05-22 10:46 ` Thomas Petazzoni [this message]
2014-05-22 10:47 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522124602.0df63a66@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox