From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Improve tar check if bsdtar is installed
Date: Fri, 30 May 2014 19:48:12 +0200 [thread overview]
Message-ID: <20140530174812.GD3474@free.fr> (raw)
In-Reply-To: <CF7F2028-8A8C-48C4-975D-E38E7621F268@web.de>
Heiko, All,
On 2014-05-30 19:40 +0200, Heiko Abraham spake thusly:
> Am 30.05.2014 um 19:16 schrieb Yann E. MORIN <yann.morin.1998@free.fr>:
> > On 2014-05-30 17:44 +0200, Heiko Abraham spake thusly:
> >> ...
> > if [ -n "${version_bsd}" ]; then
> >> + # mark as invalid tar version
> >> + major=1
> >> + minor=14
> >> + bugfix=1
> >
> > Any reason you used 1.14.1? To be obvious that this is an invalid
> > version, I'd have set it to something like:
> > major=0
> > minor=0
>
> yes, we can should version 1.16.0 instead version 1.14.1. This may be better.
> With this suggestion I will prepare a new patch.
I think using 0.0 is even better: it is clearly an invalid version.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-05-30 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 15:44 [Buildroot] [PATCH] Improve tar check if bsdtar is installed Heiko Abraham
2014-05-30 17:16 ` Yann E. MORIN
2014-05-30 17:40 ` Heiko Abraham
2014-05-30 17:48 ` Yann E. MORIN [this message]
2014-05-30 18:24 ` Thomas De Schampheleire
2014-05-30 22:10 ` [Buildroot] [PATCH v2] " Heiko Abraham
2014-05-30 22:18 ` Yann E. MORIN
2014-05-31 7:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530174812.GD3474@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox