Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Improve tar check if bsdtar is installed
Date: Sat, 31 May 2014 00:18:40 +0200	[thread overview]
Message-ID: <20140530221840.GI3474@free.fr> (raw)
In-Reply-To: <1401487838-4010-1-git-send-email-abrahamh@web.de>

Heiko, All,

On 2014-05-31 00:10 +0200, Heiko Abraham spake thusly:
> If bsdtar is installed, fix script error for tar version detection.
> 
> bsdtar not provide all expected command line (long) options

bsdtar _does_ not provide [...]

> like "--hard-dereference". To ensure compatibly mark version
> of tar as 'invalid' and trigger rebuild of 'host-tar'.
> 
> Signed-off-by: Heiko Abraham <abrahamh@web.de>

Except for the minor nit in the commit log, which can be fixed by
Peter when he commits:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  support/dependencies/check-host-tar.sh | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/support/dependencies/check-host-tar.sh b/support/dependencies/check-host-tar.sh
> index 2cfc2b3..932d3c4 100755
> --- a/support/dependencies/check-host-tar.sh
> +++ b/support/dependencies/check-host-tar.sh
> @@ -14,10 +14,17 @@ fi
>  # Output of 'tar --version' examples:
>  # tar (GNU tar) 1.15.1
>  # tar (GNU tar) 1.25
> +# bsdtar 2.8.3 - libarchive 2.8.3
>  version=`$tar --version | head -n 1 | sed 's/^.*\s\([0-9]\+\.\S\+\).*$/\1/'`
>  major=`echo "$version" | cut -d. -f1`
>  minor=`echo "$version" | cut -d. -f2`
>  bugfix=`echo "$version" | cut -d. -f3`
> +version_bsd=`$tar --version | grep 'bsdtar'`
> +if [ ! -z "${version_bsd}" ] ; then 
> +  # mark as invalid version - not all command line options are available
> +  major=0
> +  minor=0
> +fi
>  
>  # Minimal version = 1.17 (previous versions do not correctly unpack archives
>  # containing hard-links if the --strip-components option is used).
> -- 
> 1.8.5.2 (Apple Git-48)
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-05-30 22:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 15:44 [Buildroot] [PATCH] Improve tar check if bsdtar is installed Heiko Abraham
2014-05-30 17:16 ` Yann E. MORIN
2014-05-30 17:40   ` Heiko Abraham
2014-05-30 17:48     ` Yann E. MORIN
2014-05-30 18:24 ` Thomas De Schampheleire
2014-05-30 22:10 ` [Buildroot] [PATCH v2] " Heiko Abraham
2014-05-30 22:18   ` Yann E. MORIN [this message]
2014-05-31  7:40   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530221840.GI3474@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox