Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] graph-depends: refactor with more color
@ 2014-05-31 19:20 Francois Perrad
  2014-05-31 19:50 ` Yann E. MORIN
  2014-05-31 20:33 ` Yann E. MORIN
  0 siblings, 2 replies; 5+ messages in thread
From: Francois Perrad @ 2014-05-31 19:20 UTC (permalink / raw)
  To: buildroot

target and host packages don't use the same background color

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 support/scripts/graph-depends | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index e2a5e1e..443ac7d 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -222,15 +222,22 @@ for dep in dependencies:
 
 # Print the attributes of a node: label and fill-color
 def print_attrs(pkg):
+    name = pkg_node_name(pkg)
     if pkg == 'all':
-        print "all [label = \"ALL\"]"
-        print "all [color=lightblue,style=filled]"
-        return
-    print "%s [label = \"%s\"]" % (pkg_node_name(pkg), pkg)
-    if mode == PKG_MODE and pkg == rootpkg:
-        print "%s [color=lightblue,style=filled]" % pkg_node_name(rootpkg)
+        label = 'ALL'
+    else:
+        label = pkg
+    if pkg == 'all' or (mode == PKG_MODE and pkg == rootpkg):
+        color = 'lightblue'
     else:
-        print "%s [color=grey,style=filled]" % pkg_node_name(pkg)
+        if pkg.startswith('host') \
+        or pkg.startswith('toolchain') \
+        or pkg.startswith('rootfs'):
+            color = 'gainsboro'
+        else:
+            color = 'grey'
+    print "%s [label = \"%s\"]" % (name, label)
+    print "%s [color=%s,style=filled]" % (name, color)
 
 # Print the dependency graph of a package
 def print_pkg_deps(depth, pkg):
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] graph-depends: refactor with more color
  2014-05-31 19:20 [Buildroot] [PATCH] graph-depends: refactor with more color Francois Perrad
@ 2014-05-31 19:50 ` Yann E. MORIN
  2014-05-31 20:33 ` Yann E. MORIN
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-05-31 19:50 UTC (permalink / raw)
  To: buildroot

Fran?ois, All,

On 2014-05-31 21:20 +0200, Francois Perrad spake thusly:
> target and host packages don't use the same background color

Interesting.

Since, I also have a series touching the graphs, I'll take your patch in
my series to do the appropriate transformations/adaptations.

Thanks!

Regards,
Yann E. MORIN.

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  support/scripts/graph-depends | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> index e2a5e1e..443ac7d 100755
> --- a/support/scripts/graph-depends
> +++ b/support/scripts/graph-depends
> @@ -222,15 +222,22 @@ for dep in dependencies:
>  
>  # Print the attributes of a node: label and fill-color
>  def print_attrs(pkg):
> +    name = pkg_node_name(pkg)
>      if pkg == 'all':
> -        print "all [label = \"ALL\"]"
> -        print "all [color=lightblue,style=filled]"
> -        return
> -    print "%s [label = \"%s\"]" % (pkg_node_name(pkg), pkg)
> -    if mode == PKG_MODE and pkg == rootpkg:
> -        print "%s [color=lightblue,style=filled]" % pkg_node_name(rootpkg)
> +        label = 'ALL'
> +    else:
> +        label = pkg
> +    if pkg == 'all' or (mode == PKG_MODE and pkg == rootpkg):
> +        color = 'lightblue'
>      else:
> -        print "%s [color=grey,style=filled]" % pkg_node_name(pkg)
> +        if pkg.startswith('host') \
> +        or pkg.startswith('toolchain') \
> +        or pkg.startswith('rootfs'):
> +            color = 'gainsboro'
> +        else:
> +            color = 'grey'
> +    print "%s [label = \"%s\"]" % (name, label)
> +    print "%s [color=%s,style=filled]" % (name, color)
>  
>  # Print the dependency graph of a package
>  def print_pkg_deps(depth, pkg):
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] graph-depends: refactor with more color
  2014-05-31 19:20 [Buildroot] [PATCH] graph-depends: refactor with more color Francois Perrad
  2014-05-31 19:50 ` Yann E. MORIN
@ 2014-05-31 20:33 ` Yann E. MORIN
  2014-06-01 13:23   ` François Perrad
  1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2014-05-31 20:33 UTC (permalink / raw)
  To: buildroot

Farn?ois, All,

On 2014-05-31 21:20 +0200, Francois Perrad spake thusly:
> target and host packages don't use the same background color
> +            color = 'gainsboro'
> +        else:
> +            color = 'grey'

The difference between 'gainsboro' and 'grey' is very light. At first, I
thought I had forgotten to apply your patch, so the difference is light.

Did you choose it on-purpose? Did you choose it because it really looks
different when printed?

I'd like we get colours that are visually different, both on-display and
printed. I'll try to find a better default that is more visually
different, and add a new option to specify alternate colours.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] graph-depends: refactor with more color
  2014-05-31 20:33 ` Yann E. MORIN
@ 2014-06-01 13:23   ` François Perrad
  2014-06-01 13:49     ` Yann E. MORIN
  0 siblings, 1 reply; 5+ messages in thread
From: François Perrad @ 2014-06-01 13:23 UTC (permalink / raw)
  To: buildroot

2014-05-31 22:33 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> Farn?ois, All,
>
> On 2014-05-31 21:20 +0200, Francois Perrad spake thusly:
>> target and host packages don't use the same background color
>> +            color = 'gainsboro'
>> +        else:
>> +            color = 'grey'
>
> The difference between 'gainsboro' and 'grey' is very light. At first, I
> thought I had forgotten to apply your patch, so the difference is light.
>
> Did you choose it on-purpose? Did you choose it because it really looks
> different when printed?

I don't like flashy color.
Feel free to experiment another set of color (don't forget black&white
printing).
See http://graphviz.org/content/color-names

Fran?ois

>
> I'd like we get colours that are visually different, both on-display and
> printed. I'll try to find a better default that is more visually
> different, and add a new option to specify alternate colours.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] graph-depends: refactor with more color
  2014-06-01 13:23   ` François Perrad
@ 2014-06-01 13:49     ` Yann E. MORIN
  0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-06-01 13:49 UTC (permalink / raw)
  To: buildroot

Fran?ois, All,

On 2014-06-01 15:23 +0200, Fran?ois Perrad spake thusly:
> 2014-05-31 22:33 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Farn?ois, All,
> >
> > On 2014-05-31 21:20 +0200, Francois Perrad spake thusly:
> >> target and host packages don't use the same background color
> >> +            color = 'gainsboro'
> >> +        else:
> >> +            color = 'grey'
> >
> > The difference between 'gainsboro' and 'grey' is very light. At first, I
> > thought I had forgotten to apply your patch, so the difference is light.
> >
> > Did you choose it on-purpose? Did you choose it because it really looks
> > different when printed?
> 
> I don't like flashy color.
> Feel free to experiment another set of color (don't forget black&white
> printing).
> See http://graphviz.org/content/color-names

OK, thanks! I kept your patch as-is, and added an option to change
the colours:
    https://www.gitorious.org/buildroot/buildroot/commit/2092984509902a1f12e30c69f413acf0f55ec0ac

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-06-01 13:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-31 19:20 [Buildroot] [PATCH] graph-depends: refactor with more color Francois Perrad
2014-05-31 19:50 ` Yann E. MORIN
2014-05-31 20:33 ` Yann E. MORIN
2014-06-01 13:23   ` François Perrad
2014-06-01 13:49     ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox