From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] sunxi-mali: use only -I${includedir} as pkg-config Cflags
Date: Sun, 1 Jun 2014 12:20:05 +0200 [thread overview]
Message-ID: <20140601102004.GB3430@free.fr> (raw)
In-Reply-To: <1401616242-5692-2-git-send-email-syntheticpp@gmx.net>
Peter, All,
On 2014-06-01 11:50 +0200, Peter K?mmel spake thusly:
> Using only -I${includedir} in common practice.
>
> Settings only -I${includedir}/GLES2 breaks Qt5's CMake files,
> because at configure time CMake only searchs the paths reported
> by pkg-config, and not even /usr/include is used as default.
Do not indent the commit log, please.
Also, I'd add the same blurb as for ti-gfx. BTW, adding this blurb would
clarify Peter's cncern about the change.
> Signed-off-by: Peter K?mmel <syntheticpp@gmx.net>
With the blurb added:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/sunxi-mali/egl.pc | 2 +-
> package/sunxi-mali/glesv2.pc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/sunxi-mali/egl.pc b/package/sunxi-mali/egl.pc
> index b062ad1..2823209 100644
> --- a/package/sunxi-mali/egl.pc
> +++ b/package/sunxi-mali/egl.pc
> @@ -8,5 +8,5 @@ Description: ARM Mali implementation of EGL
> Version: 1.4
> Requires:
> Libs: -L${libdir} -lEGL -lGLESv2 -lUMP
> -Cflags: -I${includedir}/EGL/ -I${includedir}
> +Cflags: -I${includedir}
>
> diff --git a/package/sunxi-mali/glesv2.pc b/package/sunxi-mali/glesv2.pc
> index 9273678..4702d13 100644
> --- a/package/sunxi-mali/glesv2.pc
> +++ b/package/sunxi-mali/glesv2.pc
> @@ -8,5 +8,5 @@ Description: ARM Mali implementation of OpenGL ESv2
> Version: 2.0
> Requires:
> Libs: -L${libdir} -lGLESv2 -lGLESv1_CM -lUMP
> -Cflags: -I${includedir}/GLES2
> +Cflags: -I${includedir}
>
> --
> 1.7.10.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-06-01 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 9:50 [Buildroot] [PATCH 1/2] ti-gfx: use only -I${includedir} as pkg-config Cflags Peter Kümmel
2014-06-01 9:50 ` [Buildroot] [PATCH 2/2] sunxi-mali: " Peter Kümmel
2014-06-01 10:20 ` Yann E. MORIN [this message]
2014-06-01 10:09 ` [Buildroot] [PATCH 1/2] ti-gfx: " Yann E. MORIN
2014-06-01 10:17 ` Peter Kümmel
-- strict thread matches above, loose matches on Subject: below --
2014-06-01 10:18 Peter Kümmel
2014-06-01 10:18 ` [Buildroot] [PATCH 2/2] sunxi-mali: " Peter Kümmel
2014-06-03 4:54 ` Peter Kümmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601102004.GB3430@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox