From: "Peter Kümmel" <syntheticpp@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ti-gfx: use only -I${includedir} as pkg-config Cflags
Date: Sun, 01 Jun 2014 12:17:47 +0200 [thread overview]
Message-ID: <538AFDCB.608@gmx.net> (raw)
In-Reply-To: <20140601100906.GA3430@free.fr>
On 01.06.2014 12:09, Yann E. MORIN wrote:
> Peter, All,
>
> On 2014-06-01 11:50 +0200, Peter K?mmel spake thusly:
>> Using only -I${includedir} in common practice.
>>
>> Settings only -I${includedir}/GLES2 breaks Qt5's CMake files,
>> because at configure time CMake only searchs the paths reported
>> by pkg-config, and not even /usr/include is used as default.
>
> I would add something like:
>
> Even though pkg-config strips out standard include path, that's not
> the case with pkgconf (which we are using) in cross-compilation,
> which correctly reports the /usr/include dir prefixed with the
> sysroot.
>
>> Signed-off-by: Peter K?mmel <syntheticpp@gmx.net>
>
> With the above blurb added in the commit log:
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Also noticed it, but I though it will be added by git send-email (at least a Cc:)
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> package/ti-gfx/egl.pc | 2 +-
>> package/ti-gfx/glesv2.pc | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/ti-gfx/egl.pc b/package/ti-gfx/egl.pc
>> index 223fb04..36ea413 100644
>> --- a/package/ti-gfx/egl.pc
>> +++ b/package/ti-gfx/egl.pc
>> @@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of EGL
>> Version: 1.9.2188537
>> Requires:
>> Libs: -L${libdir} -lEGL -lGLESv2 -lIMGegl
>> -Cflags: -I${includedir}/EGL/ -I${includedir}
>> +Cflags: -I${includedir}
>> diff --git a/package/ti-gfx/glesv2.pc b/package/ti-gfx/glesv2.pc
>> index 4c70aec..b458133 100644
>> --- a/package/ti-gfx/glesv2.pc
>> +++ b/package/ti-gfx/glesv2.pc
>> @@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL ESv2
>> Version: 1.9.2188537
>> Requires:
>> Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
>> -Cflags: -I${includedir}/GLES2
>> +Cflags: -I${includedir}
>> --
>> 1.7.10.4
>>
>
next prev parent reply other threads:[~2014-06-01 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 9:50 [Buildroot] [PATCH 1/2] ti-gfx: use only -I${includedir} as pkg-config Cflags Peter Kümmel
2014-06-01 9:50 ` [Buildroot] [PATCH 2/2] sunxi-mali: " Peter Kümmel
2014-06-01 10:20 ` Yann E. MORIN
2014-06-01 10:09 ` [Buildroot] [PATCH 1/2] ti-gfx: " Yann E. MORIN
2014-06-01 10:17 ` Peter Kümmel [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-01 10:18 Peter Kümmel
2014-06-03 4:54 ` Peter Kümmel
2014-06-08 16:53 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538AFDCB.608@gmx.net \
--to=syntheticpp@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox