Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 2/2] glibc: add eglibc 2.19-svnr25243 and choice menu
Date: Sun, 1 Jun 2014 15:24:59 +0300	[thread overview]
Message-ID: <20140601122459.GF4280@tarshish> (raw)
In-Reply-To: <1401623919-16671-2-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

On Sun, Jun 01, 2014 at 08:58:39AM -0300, Gustavo Zacarias wrote:
> Add glibc 2.19-svnr25243 and a choice menu to select between different
> eglibc versions.
> Blacklist it for PowerPC SPE since it's broken.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/glibc/Config.in | 17 +++++++++++++++++
>  package/glibc/glibc.mk  |  2 +-
>  2 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/package/glibc/Config.in b/package/glibc/Config.in
> index dbb1a19..494c0f9 100644
> --- a/package/glibc/Config.in
> +++ b/package/glibc/Config.in
> @@ -1,3 +1,20 @@
> +if BR2_TOOLCHAIN_BUILDROOT_EGLIBC
> +
> +choice
> +	prompt "eglibc version"
> +	default BR2_EGLIBC_VERSION_2_18
> +
> +config BR2_EGLIBC_VERSION_2_18
> +	bool "2.18-svnr23787"
> +
> +config BR2_EGLIBC_VERSION_2_19
> +	bool "2.19-svnr25243"
> +	depends on !BR2_powerpc_SPE
> +
> +endchoice
> +
> +endif
> +
>  if BR2_TOOLCHAIN_BUILDROOT_GLIBC
>  
>  choice
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index d02ab7e..f841fd0 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  ifeq ($(BR2_TOOLCHAIN_BUILDROOT_EGLIBC),y)
> -GLIBC_VERSION = 2.18-svnr23787
> +GLIBC_VERSION = $(if $(BR2_EGLIBC_VERSION_2_19),2.19-svnr25243,2.18-svnr23787)

Is it possible to use BR2_EGLIBC_VERSION_2_1{8,9} here and avoid version 
string duplication?

baruch

>  GLIBC_SITE = http://downloads.yoctoproject.org/releases/eglibc/
>  GLIBC_SOURCE = eglibc-$(GLIBC_VERSION).tar.bz2
>  GLIBC_SRC_SUBDIR = libc

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-06-01 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01 11:58 [Buildroot] [PATCHv2 1/2] glibc: drop redundant arch depends Gustavo Zacarias
2014-06-01 11:58 ` [Buildroot] [PATCHv2 2/2] glibc: add eglibc 2.19-svnr25243 and choice menu Gustavo Zacarias
2014-06-01 12:24   ` Baruch Siach [this message]
2014-06-01 12:29     ` Gustavo Zacarias
2014-06-01 12:34   ` Thomas Petazzoni
2014-06-01 12:46     ` Gustavo Zacarias
2014-06-01 12:56       ` Thomas Petazzoni
2014-06-01 12:32 ` [Buildroot] [PATCHv2 1/2] glibc: drop redundant arch depends Thomas Petazzoni
2014-06-01 18:58 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140601122459.GF4280@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox