From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 2/2] glibc: add eglibc 2.19-svnr25243 and choice menu
Date: Sun, 1 Jun 2014 14:56:00 +0200 [thread overview]
Message-ID: <20140601145600.1222fac1@free-electrons.com> (raw)
In-Reply-To: <538B20BA.5040600@zacarias.com.ar>
Dear Gustavo Zacarias,
On Sun, 01 Jun 2014 09:46:50 -0300, Gustavo Zacarias wrote:
> > I'd like to see a comment above this dependency that explains why we
> > have this dependency: it's not because there is no support for PowerPC
> > SPE, but only because it's broken, so a future bump to a newer version
> > of eglibc 2.19 might fix the problem.
>
> Ok.
> For the record there are other commits in a similar vein that didn't get
> that benefit, and it's build breakage (so quite obvious to test & catch).
Yeah, might be the case. I'm not at all pretending that the rest of the
code is perfect. Just pointing out that this particular patch could be
improved by having a little comment, IMO.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-01 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 11:58 [Buildroot] [PATCHv2 1/2] glibc: drop redundant arch depends Gustavo Zacarias
2014-06-01 11:58 ` [Buildroot] [PATCHv2 2/2] glibc: add eglibc 2.19-svnr25243 and choice menu Gustavo Zacarias
2014-06-01 12:24 ` Baruch Siach
2014-06-01 12:29 ` Gustavo Zacarias
2014-06-01 12:34 ` Thomas Petazzoni
2014-06-01 12:46 ` Gustavo Zacarias
2014-06-01 12:56 ` Thomas Petazzoni [this message]
2014-06-01 12:32 ` [Buildroot] [PATCHv2 1/2] glibc: drop redundant arch depends Thomas Petazzoni
2014-06-01 18:58 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601145600.1222fac1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox