[Buildroot] Patch: qt5webkitexamples

[Buildroot] Patch: qt5webkitexamples

[Massimo Callegari]

Hi, attached a patch that adds the missing qt5 webkit examples module.

One thing though. Have you ever considered migrating to GitHub ?
Submitting patches via email is, in my opinion, extremely inefficient and can lead to human errors.

GitHub, on the other hand, encourages open source communities and reduce errors to the minimum.

Cheers,
Massimo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140606/7f065171/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qt5webkitexamples.patch
Type: text/x-patch
Size: 2963 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140606/7f065171/attachment.bin>

[Buildroot] Patch: qt5webkitexamples

[Mike Zick]

On Fri, 6 Jun 2014 16:16:13 +0100 (BST)
Massimo Callegari <massimocallegari@yahoo.it> wrote:

> Hi, attached a patch that adds the missing qt5 webkit examples module.
> 
> One thing though. Have you ever considered migrating to GitHub ?
> Submitting patches via email is, in my opinion, extremely inefficient
> and can lead to human errors.
> 

Please put your patch **in-line** rather than as an attachment.

> GitHub, on the other hand, encourages open source communities and
> reduce errors to the minimum.
>

The **in-line** of patches allows all readers of this list easy
access to reviewing the submissions.

Mike 
> Cheers,
> Massimo

[Buildroot] Patch: qt5webkitexamples

[Thomas Petazzoni]

Dear Massimo Callegari,

On Fri, 6 Jun 2014 16:16:13 +0100 (BST), Massimo Callegari wrote:

> Hi, attached a patch that adds the missing qt5 webkit examples module.

Thanks for your contribution! However, as Mike Zick said, and as
explained in the Buildroot manual, patches should be submitted inline.
The 'git send-email' tool does that for you.

> One thing though. Have you ever considered migrating to GitHub ?
> Submitting patches via email is, in my opinion, extremely inefficient and can lead to human errors.

Which human errors? If you use 'git send-email', there is no problem at
all, and sending patches just requires one command.

Submitting patches on a mailing list allows people to easily review
them, discuss comments. Buildroot is by far not the only community to
do this. Other major communities in the embedded Linux space do the
same: the kernel, U-Boot, Barebox and others.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] Patch: qt5webkitexamples

[Massimo Callegari]

Hello Thomas,
then I clearly haven't read the whole guidelines in the BR manual. Apologies for that.

I am totally aware that the patch system this project adopted is working since years. Mine was just a suggestion since I work on a daily basis with GitHub and I find it simply splendid for code review.
Maybe it's just my impression but the flow "fork -> patch -> pull request" sounds easier than manual git commands where you have to remember the email address of a mailing list (thus human errors...) and where dozens of emails float around every day even to users not interested in a particular topic.
In my opinion a mailing list should be used only to discuss bugs, ideas and help users. In the current way, users emails risk to get lost into a ton of [PATCH] emails.
Maybe a ML dedicated to patches could help ?

On GitHub users can add inline comments to a patch and you can even share a URL to a specific line of code !

Anyway, I'm not complaining or trying to teach you something. Just sharing my opinion.
I've seen BR is actually on GitHub, but it's 2 months behind the current developments. Is that a "dead" idea or lack of interest/time ?

If you want, I'll try to submit my patch again on monday using git send-email. The patch is very simple, if you can review it as it is it would save me a bit of time and speed things up.

Best regards,
Massimo



>________________________________
> Da: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>A: Massimo Callegari <massimocallegari@yahoo.it> 
>Cc: "buildroot at busybox.net" <buildroot@busybox.net> 
>Inviato: Sabato 7 Giugno 2014 12:23
>Oggetto: Re: [Buildroot] Patch: qt5webkitexamples
> 
>
>Dear Massimo Callegari,
>
>On Fri, 6 Jun 2014 16:16:13 +0100 (BST), Massimo Callegari wrote:
>
>> Hi, attached a patch that adds the missing qt5 webkit examples module.
>
>Thanks for your contribution! However, as Mike Zick said, and as
>explained in the Buildroot manual, patches should be submitted inline.
>The 'git send-email' tool does that for you.
>
>
>
>
>
>> One thing though. Have you ever considered migrating to GitHub ?
>> Submitting patches via email is, in my opinion, extremely inefficient and can lead to human errors.
>
>Which human errors? If you use 'git send-email', there is no problem at
>all, and sending patches just requires one command.
>
>Submitting patches on a mailing list allows people to easily review
>them, discuss comments. Buildroot is by far not the only community to
>do this. Other major communities in the embedded Linux space do the
>same: the kernel, U-Boot, Barebox and others.
>
>Best regards,
>
>Thomas
>-- 
>Thomas Petazzoni, CTO, Free Electrons
>Embedded Linux, Kernel and Android engineering
>http://free-electrons.com
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140607/f1f757a2/attachment.html>

[Buildroot] Patch: qt5webkitexamples

[Mike Zick]

On Sat, 7 Jun 2014 11:47:41 +0100 (BST)
Massimo Callegari <massimocallegari@yahoo.it> wrote:

> Hello Thomas,
> then I clearly haven't read the whole guidelines in the BR manual.
> Apologies for that.
> 
> I am totally aware that the patch system this project adopted is
> working since years. Mine was just a suggestion since I work on a
> daily basis with GitHub and I find it simply splendid for code
> review. Maybe it's just my impression but the flow "fork -> patch ->
> pull request" sounds easier than manual git commands where you have
> to remember the email address of a mailing list (thus human
> errors...) and where dozens of emails float around every day even to
> users not interested in a particular topic. In my opinion a mailing
> list should be used only to discuss bugs, ideas and help users. In
> the current way, users emails risk to get lost into a ton of [PATCH]
> emails. Maybe a ML dedicated to patches could help ?
> 

This mailing list uses dedicated tags in the subject line.
Just set your e-mail client to filter by the tag into different
sub-directories.

Then you don't have to look in (for example) BuildRoot/BR_Patch
directory unless you want to.  ;)

Same with commit, bug and autobuilder messages.

No, I am not trying to be stubborn, it is just a system that the
developers are comfortable with.

I find (I am a 99.9% read-only ML member) a bit of e-mail filtering
helps a lot in dealing with the flood of information here. ;)

Mike

[Buildroot] Patch: qt5webkitexamples

[Thomas Petazzoni]

Dear Massimo Callegari,

On Sat, 7 Jun 2014 11:47:41 +0100 (BST), Massimo Callegari wrote:

> then I clearly haven't read the whole guidelines in the BR manual.
> Apologies for that.

No problem :-)

> I am totally aware that the patch system this project adopted is
> working since years. Mine was just a suggestion since I work on a
> daily basis with GitHub and I find it simply splendid for code
> review. Maybe it's just my impression but the flow "fork -> patch ->
> pull request" sounds easier than manual git commands where you have
> to remember the email address of a mailing list (thus human
> errors...)

I can help you solve this particular "human error" very easily. Edit
the .git/config file in your Buildroot Git clone, and add:

[sendemail]
        to = buildroot at uclibc.org

Then, you can directly use "git send-email" and it will automatically
send the patches to the mailing list.

> and where dozens of emails float around every day even to
> users not interested in a particular topic. In my opinion a mailing
> list should be used only to discuss bugs, ideas and help users. In
> the current way, users emails risk to get lost into a ton of [PATCH]
> emails. Maybe a ML dedicated to patches could help ?

This has been discussed in previous Buildroot meetings. See
http://elinux.org/Buildroot:DeveloperDaysELCE2013#Community_organization:

"""
The number of mails on the list: it's about 150 e-mails a day, so we
suspect that people who are just using buildroot are scared off from
the list. Hence the idea of splitting the list. Putting the git commits
on a separate mailing list is certainly a possibility, but is going to
remove only 300 of the 2000 mails per month. We don't see a good way to
split the lists at all, because a basic user is very quickly a basic
developer and forcing them to see the patches is probably good. Also
having to subscribe to such a big list is a big threshold. But opening
it to non-subscribers is not a good idea.
"""

> Anyway, I'm not complaining or trying to teach you something. Just
> sharing my opinion. I've seen BR is actually on GitHub, but it's 2
> months behind the current developments. Is that a "dead" idea or lack
> of interest/time ?

It's just that I haven't automated the task of updating our Github
clone, so I only do it from time to time.

> If you want, I'll try to submit my patch again on monday using git
> send-email. The patch is very simple, if you can review it as it is
> it would save me a bit of time and speed things up.

Sure, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] Patch: qt5webkitexamples

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> Anyway, I'm not complaining or trying to teach you something. Just
 >> sharing my opinion. I've seen BR is actually on GitHub, but it's 2
 >> months behind the current developments. Is that a "dead" idea or
 >> lack of interest/time ?

 > It's just that I haven't automated the task of updating our Github
 > clone, so I only do it from time to time.

It would be good if you could add a cronjob to do it daily or so (or I
can do it if you prefer). Is there an easy way to inform users that this
is just a mirror and we would like contributors to use the mailing list
instead of the github features?

-- 
Bye, Peter Korsgaard

[Buildroot] Patch: qt5webkitexamples

[Thomas Petazzoni]

Dear Peter Korsgaard,

Yes, reviving a very old thread.

On Mon, 09 Jun 2014 23:12:19 +0200, Peter Korsgaard wrote:

>  > It's just that I haven't automated the task of updating our Github
>  > clone, so I only do it from time to time.
> 
> It would be good if you could add a cronjob to do it daily or so (or I
> can do it if you prefer). Is there an easy way to inform users that this
> is just a mirror and we would like contributors to use the mailing list
> instead of the github features?

This is now done:

 *) I've added a cronjob that updates the Github mirror automatically.
    A special Github user buildroot-auto-update has been created, which
    uses a special SSH key with no passphrase, used by my cronjob to do
    the update of the Github repository. It is updated every 10 minutes.

 *) I've added a mention at https://github.com/buildroot/buildroot that
    this is not the official Git repository.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com