From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] rsync forces configure step
Date: Fri, 13 Jun 2014 14:09:08 +0200 [thread overview]
Message-ID: <20140613140908.532d1852@free-electrons.com> (raw)
In-Reply-To: <1f09233e5be11d75394054a20c4631cd@openmailbox.org>
Dear C?dric Marie,
On Fri, 13 Jun 2014 10:54:20 +0200, C?dric Marie wrote:
> I have recently upgraded from Buildroot 2014.02 to 2014.05, and I have
> noticed that some developments related to top-level parallel build have
> resulted in a small change of behaviour, which I would consider as a
> regression.
>
> When a package is used in rsync mode, make <pkg>-rebuild also forces the
> configure step.
>
> This has been introduced by this commit:
> http://git.buildroot.net/buildroot/commit/package/pkg-generic.mk?id=6c5c08b854e4490697076ae3c5a9c587d8672c63
> ... and this line in particular:
> $$($(2)_TARGET_CONFIGURE): $$($(2)_TARGET_RSYNC)
>
> I believe the right way to support parallel build without forcing the
> configure step in case of rsync, is to use an order-only prerequisite
> (with a pipe):
> $$($(2)_TARGET_CONFIGURE): | $$($(2)_TARGET_RSYNC)
>
> I have checked this correction successfully.
This indeed seems correct. I've Cc'ed Fabio who is working on the
top-level parallel build feature, I guess he'll have a look and give
you more feedback and/or send a patch fixing this issue.
Thanks a lot for the report!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-13 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 8:54 [Buildroot] rsync forces configure step Cédric Marie
2014-06-13 12:09 ` Thomas Petazzoni [this message]
2014-06-13 12:15 ` Fabio Porcedda
2014-06-30 8:02 ` Cédric Marie
2014-06-30 8:04 ` Fabio Porcedda
2014-06-30 8:55 ` Fabio Porcedda
2014-06-30 9:05 ` Fabio Porcedda
2014-06-30 9:07 ` Cédric Marie
2014-06-30 9:18 ` Fabio Porcedda
2014-06-30 9:39 ` Thomas Petazzoni
2014-06-30 9:42 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613140908.532d1852@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox