Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Marie" <cedric.marie@openmailbox.org>
To: buildroot@busybox.net
Subject: [Buildroot] rsync forces configure step
Date: Mon, 30 Jun 2014 11:07:21 +0200	[thread overview]
Message-ID: <a7922ce4ddeebd771edf07275a858ebb@openmailbox.org> (raw)
In-Reply-To: <CAHkwnC8mKP2KyFRre_fQto7mJWop0m5D3L3ReKmpD7XGsEoNXg@mail.gmail.com>

Le 2014-06-30 10:55, Fabio Porcedda a ?crit?:
> The problem is that the stamp file for rsync is being removed with the
> "<pkg>-rebuild" command, so i think that the right fix is:
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 54193d2..67821ec 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -569,9 +569,6 @@ $(1)-graph-depends: graph-depends-requirements
>  $(1)-dirclean:         $$($(2)_TARGET_DIRCLEAN)
> 
>  $(1)-clean-for-rebuild:
> -ifneq ($$($(2)_OVERRIDE_SRCDIR),)
> -                       rm -f $$($(2)_TARGET_RSYNC)
> -endif
>                         rm -f $$($(2)_TARGET_BUILD)
>                         rm -f $$($(2)_TARGET_INSTALL_STAGING)
>                         rm -f $$($(2)_TARGET_INSTALL_TARGET)
> 
> The problem is not related to top-level parallel build, the problem
> was present even the previous release (2014.02), the problem was
> always existed sine the introduction of the "<pk>-rebuild" feature:
> 
> http://git.buildroot.net/buildroot/commit/?id=4ed4e5016b741341059ed826416dad3291df0b2c
> Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Date:   Thu Sep 29 21:57:39 2011 +0200
>    package: add <pkg>-rebuild and <pkg>-reconfigure
> 
> Thomas do you know why you removed the sync stamp file?
> 
> BR


Sorry, but I believe that removing the rsync stamp file is necessary 
when rebuilding.
When you modify your local source files, you want them to be 
synchronized when rebuilding.
The regression is forcing the configure step, which was not present in 
2014.02.

Regards,

-- 
C?dric

  parent reply	other threads:[~2014-06-30  9:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  8:54 [Buildroot] rsync forces configure step Cédric Marie
2014-06-13 12:09 ` Thomas Petazzoni
2014-06-13 12:15   ` Fabio Porcedda
2014-06-30  8:02     ` Cédric Marie
2014-06-30  8:04       ` Fabio Porcedda
2014-06-30  8:55         ` Fabio Porcedda
2014-06-30  9:05           ` Fabio Porcedda
2014-06-30  9:07           ` Cédric Marie [this message]
2014-06-30  9:18             ` Fabio Porcedda
2014-06-30  9:39           ` Thomas Petazzoni
2014-06-30  9:42             ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7922ce4ddeebd771edf07275a858ebb@openmailbox.org \
    --to=cedric.marie@openmailbox.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox