[Buildroot] [PATCH] graph-depends: fix when $(O) is a relative path

[Yann E. MORIN <yann.morin.1998@free.fr>]

Arnout, All,

On 2014-06-23 21:16 +0200, Arnout Vandecappelle spake thusly:
> On 23/06/14 19:03, Yann E. MORIN wrote:
> > On 2014-06-23 07:28 +0200, Arnout Vandecappelle spake thusly:
> >> On 20/06/14 22:55, Yann E. MORIN wrote:
> >>> On 2014-06-19 00:10 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> >>>> The graph-depends commands cd into the CONFIG_DIR and run the script
> >>>> from there. However, this means that when $(O) is a relative path, it
> >>>> will no longer be correct.  Therefore, use $(BASE_DIR) instead of $(O).
> >>>>
> >>>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >>> I tried with thisscript, and did not notice any difference between the
> >>> two runs, one with master, the second with the patch applied:
> > [--SNIP long script--]
> >>  First of all, for me all these cases succeed both with and without the patch.
> > 
> > You mean all the 6 cases do work for you? Weird.
> > 
> > I don't see how it can work, since calling this
> >     make -C buildroot O=somewhere goal
> > 
> > will not have the --no-print-directory option, and thus make would print
> > its usual "Entering/Leaving directory blabla" which confuses
> > graph-depends.py
> 
>  Oh sorry, I didn't look at the output, just that it doesn't error out.

OK, no problem. ;-)

make does not error out, because of the pipe, which only returns the
status of the last command in the pipe. We can't do much about this...

> > There is not much we can do about that, since our out-of-tree Makefile
> > wrapper is never called.
> > 
> > Even worse, if you do
> >     make -C buildroot O=somewhere defconfig
> >     make -C somewhere graph-depends
> > 
> > then even though we do use our Makefile wrapper in this case, the
> > --no-print-directory option is not used! So make would still print its
> > "Entering/Leaving directory blabla" (and thus graph-depends will get
> > confused.)
> 
>  So why don't we just add --no-print-directory to the recursive make invocation
> from the script? Patch follows...

Thanks! :-)

> >> Using any other combination of . and .. a $(O)
> >> triggers the problem. So try
> >>
> >> do_prep br-7
> >> make -C br-7 O=./br.build-7 defconfig
> >> make -C br-7 O=./br.build-7 graph-depends
> 
>  This one I didn't actually run like this, but like:
> 
> make O=br.build-7 defconfig
> make O=br.build-7 graph-depends
> 
> (from the buildroot directory). For that one, I checked that the PDF was OK, and
> then I just wrote it with -C in the mail. Stupid of me.

Well, that's yet another test-case! :-)

OK, thanks for bearing with me all along! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'