From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] graph-depends: fix when $(O) is a relative path
Date: Fri, 20 Jun 2014 22:07:14 +0200 [thread overview]
Message-ID: <53A49472.4050109@mind.be> (raw)
In-Reply-To: <20140620200457.GA3543@free.fr>
On 20/06/14 22:04, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2014-06-19 00:10 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
>> The graph-depends commands cd into the CONFIG_DIR and run the script
>> from there. However, this means that when $(O) is a relative path, it
>> will no longer be correct. Therefore, use $(BASE_DIR) instead of $(O).
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Tested with this sequence:
> cd buildroot
> make manual-html
> make O=../br.build-1 manual-html
> cd ..
> make -C buildroot O=../br.build-2 manual-html
> make -C buildroot O=$(pwd)/br.build-3
> mkdir br.build-4
> cd br.build-4
> make defconfig (to create the Makefile wrapper)
> make manual-html
Call me stupid, but why is it relevant to test this patch with manual-html?
Regards,
Arnout
>
> All generate the HTML manual, and a cursory look does not show any
> diference.
>
> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> Makefile | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 5c82355..dd350b6 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -676,8 +676,8 @@ graph-depends:
>> @$(INSTALL) -d $(O)/graphs
>> @cd "$(CONFIG_DIR)"; \
>> $(TOPDIR)/support/scripts/graph-depends $(BR2_GRAPH_DEPS_OPTS) \
>> - |tee $(O)/graphs/$(@).dot \
>> - |dot $(BR2_GRAPH_DOT_OPTS) -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)
>> + |tee $(BASE_DIR)/graphs/$(@).dot \
>> + |dot $(BR2_GRAPH_DOT_OPTS) -T$(BR_GRAPH_OUT) -o $(BASE_DIR)/graphs/$(@).$(BR_GRAPH_OUT)
>>
>> else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
>>
>> --
>> 2.0.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-06-20 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 22:10 [Buildroot] [PATCH] graph-depends: fix when $(O) is a relative path Arnout Vandecappelle
2014-06-20 20:04 ` Yann E. MORIN
2014-06-20 20:07 ` Arnout Vandecappelle [this message]
2014-06-20 20:14 ` Yann E. MORIN
2014-06-23 20:51 ` Yann E. MORIN
2014-06-20 20:55 ` Yann E. MORIN
2014-06-23 5:28 ` Arnout Vandecappelle
2014-06-23 17:03 ` Yann E. MORIN
2014-06-23 19:16 ` Arnout Vandecappelle
2014-06-23 20:48 ` Yann E. MORIN
2014-06-29 8:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A49472.4050109@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox