From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V5 1/2] google-breakpad: new package
Date: Sun, 29 Jun 2014 12:30:43 +0200 [thread overview]
Message-ID: <20140629123043.5bbe78c7@free-electrons.com> (raw)
In-Reply-To: <1403702174-23850-2-git-send-email-pascal.huerst@gmail.com>
Dear Pascal Huerst,
On Wed, 25 Jun 2014 15:16:13 +0200, Pascal Huerst wrote:
> Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
> ---
> package/Config.in | 1 +
> package/google-breakpad/Config.in | 19 +++++++++++++++++++
> package/google-breakpad/google-breakpad.mk | 17 +++++++++++++++++
> 3 files changed, 37 insertions(+)
> create mode 100644 package/google-breakpad/Config.in
> create mode 100644 package/google-breakpad/google-breakpad.mk
Thanks, I've applied your patch, after making some changes according to
Arnout comments. From the commit log:
[Thomas:
- Introduce a BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS Config.in
symbol to be able to easily propagate the architecture
dependencies.
- Wrap the help text, add some more details as suggested by Arnout.
- Propagate the architecture dependencies to the comment, as
suggested by Arnout.
- Remove the dependency of google-breakpad on host-google-breakpad,
since it's not needed.
- Add <pkg>_TARGET = NO, because google-breakpad only installs a
static library, so installation to staging is sufficient.
- Reorder autotools-package/host-autotools-package invocations, as
suggested by Arnout.]
Also, could you explain why you're passing --disable-processor when
building the target package google-breakpad?
For the second patch adding the core support for google-breakpad, there
is still some on-going discussion, so I believe it's not ready to be
applied yet.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-29 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 13:16 [Buildroot] [PATCH V5 0/2] google-breakpad: new package Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 1/2] " Pascal Huerst
2014-06-25 19:16 ` Arnout Vandecappelle
2014-06-29 10:30 ` Thomas Petazzoni [this message]
2014-07-02 12:59 ` Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 2/2] google-breakpad: integration into Makefile and Config.in Pascal Huerst
2014-06-25 20:31 ` Arnout Vandecappelle
2014-06-29 10:36 ` Thomas Petazzoni
2014-07-01 6:19 ` Arnout Vandecappelle
2014-07-09 9:48 ` Pascal Huerst
2014-07-09 9:39 ` Pascal Huerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140629123043.5bbe78c7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox