Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Huerst <pascal.huerst@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V5 2/2] google-breakpad: integration into Makefile and Config.in
Date: Wed, 09 Jul 2014 11:39:17 +0200	[thread overview]
Message-ID: <53BD0DC5.50501@gmail.com> (raw)
In-Reply-To: <20140629123618.407b95f5@free-electrons.com>

Hey Thomas, Arnout, all

-- snip --

> However, I don't really like the prompt. Maybe it should be:
> 
> 	[ ] Enable Google Breakpad support
> 	   () List of binaries to extract symbols from
> 
>>> +ifeq ($(BR2_PACKAGE_GOOGLE_BREAKPAD),y)
>>> +	$(EXTRA_ENV) package/google-breakpad/gen-syms.sh $(STAGING_DIR) \
>>> +		$(TARGET_DIR) $(call qstrip,$(BR2_GOOGLE_BREAKPAD_INCLUDE_FILES))
>>
>>  To be more compatible with Fabio's series that reworks this part of the
>> infrastructure, it's better to define this as a new variable which is called
>> here. That will make it easier to resolve the conflict between these two series.
>> Fabio's series will also make it possible to define this completely inside the
>> google-breakpad.mk.

Can you give me a hint, on how this should be done then?

> Yes, having it all in the google-breakpad.mk seems like a good idea.
> 
> Thomas
> 

Pascal

      parent reply	other threads:[~2014-07-09  9:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 13:16 [Buildroot] [PATCH V5 0/2] google-breakpad: new package Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 1/2] " Pascal Huerst
2014-06-25 19:16   ` Arnout Vandecappelle
2014-06-29 10:30   ` Thomas Petazzoni
2014-07-02 12:59     ` Pascal Huerst
2014-06-25 13:16 ` [Buildroot] [PATCH V5 2/2] google-breakpad: integration into Makefile and Config.in Pascal Huerst
2014-06-25 20:31   ` Arnout Vandecappelle
2014-06-29 10:36     ` Thomas Petazzoni
2014-07-01  6:19       ` Arnout Vandecappelle
2014-07-09  9:48         ` Pascal Huerst
2014-07-09  9:39       ` Pascal Huerst [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD0DC5.50501@gmail.com \
    --to=pascal.huerst@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox