[Buildroot] [PATCH 1/1] libssh2: fix library search path issues when zlib support enabled

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Arnout Vandecappelle,

On Wed, 02 Jul 2014 08:18:08 +0200, Arnout Vandecappelle wrote:

>  However, I see in the configure script at line 14539:
> 
>     eval additional_libdir=\"$libdir\"
> 
> and a bit lower, at line 14616:
> 
>             dir="$additional_libdir"
>                                     if test -n "$acl_shlibext"; then
>               if test -f "$dir/$libname$shrext"; then
>                 found_dir="$dir"
>                 found_so="$dir/$libname$shrext"
> 
>  Since libdir is /usr/lib, it will indeed find libz there.
> 
>  I guess, Thomas, that on your machine, libz.so is in /usr/lib64 so configure
> doesn't find it there.

Right, it's in /usr/lib/x86_64-linux-gnu.

>  But basically that means this configure script is truly broken, not just for
> libz but for any use of AC_LIB_HAVE_LINKFLAGS...
> 
>  Perhaps AUTORECONF will help?

Alexandre, can you try to add LIBSSH2_AUTORECONF = YES to libssh2.mk,
in replacement to your fix?

That being said, there are a number of packages for which we explicitly
pass a --with-<foo>=$(STAGING_DIR), so it's not completely crazy to do
the same for libssh2, no?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com