From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libssh2: fix library search path issues when zlib support enabled
Date: Wed, 2 Jul 2014 09:58:29 +0200 [thread overview]
Message-ID: <20140702095829.79ba2c59@free-electrons.com> (raw)
In-Reply-To: <53B3B9A5.9020803@mind.be>
Dear Arnout Vandecappelle,
On Wed, 02 Jul 2014 09:49:57 +0200, Arnout Vandecappelle wrote:
> > Alexandre, can you try to add LIBSSH2_AUTORECONF = YES to libssh2.mk,
> > in replacement to your fix?
>
> Don't bother, it won't help. This thing is defined in m4/lib-link.m4 (lines
> 154-155) within libssh2 itself. So we'll need to patch that file and _then_ run
> autoreconf.
So we need to patch that and send a fix upstream, no?
> > That being said, there are a number of packages for which we explicitly
> > pass a --with-<foo>=$(STAGING_DIR), so it's not completely crazy to do
> > the same for libssh2, no?
>
> Yes, but then it should be done for _all_ libraries used by libssh2, because it
> uses this $additional_libdir failure in a lot of places.
Indeed. Alexandre, could you have a look at this, either fixing the
root of the problem (best solution), or pass the --with-<foo> option
for all libraries that libssh2 can rely on?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-02 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 14:18 [Buildroot] [PATCH 1/1] libssh2: fix library search path issues when zlib support enabled Alexandre Coffignal
2014-06-29 14:30 ` Thomas Petazzoni
2014-06-30 11:43 ` COFFIGNAL Alexandre
2014-06-30 12:02 ` Thomas Petazzoni
2014-06-30 12:33 ` Alexandre COFFIGNAL
2014-07-02 6:18 ` Arnout Vandecappelle
2014-07-02 7:26 ` Thomas Petazzoni
2014-07-02 7:49 ` Arnout Vandecappelle
2014-07-02 7:58 ` Thomas Petazzoni [this message]
2014-07-02 8:56 ` Alexandre COFFIGNAL
2014-07-02 7:53 ` Alexandre COFFIGNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702095829.79ba2c59@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox