[Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Peter Korsgaard,

On Wed, 02 Jul 2014 17:28:04 +0200, Peter Korsgaard wrote:

> Thanks. I've verified that the (non-gzip'ed) tarball is identical to
> what we had before, but I noticed that we no longer delete the temporary
> repo in DL_DIR.
> 
> Did you do that change on purpose? I don't think we want to keep it, do
> we?

Hum, I'm confused, didn't we say that we should no longer do any
temporary thing in $(DL_DIR) in order to allow parallel builds of
separate Buildroot instances to not mess up with each other? I think we
said that the process should be:

 1/ Clone the repo in $(BUILD_DIR)
 2/ Create the tarball of the repo in $(BUILD_DIR)
 3/ Move the tarball from $(BUILD_DIR) to $(DL_DIR) with a temporary
    unique file name.
 4/ Rename the tarball in $(DL_DIR) to its final name

Steps (3) and (4) are separated so that if $(DL_DIR) and $(BUILD_DIR)
are in separate filesystems, the rename to the final name remains an
atomic operation.

And yes, the git download helper from Yann doesn't seem to implement
this logic (or I got lost with the variable names, which is very
possible).

Yann?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com