From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script
Date: Wed, 02 Jul 2014 23:42:41 +0200 [thread overview]
Message-ID: <877g3vbfou.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140702203748.GC9383@free.fr> (Yann E. MORIN's message of "Wed, 2 Jul 2014 22:37:48 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
>> I think what Peter complains about is that with just PATCH 03/14
>> applied, the Git download method no longer works properly as it leaves
>> the repo in $(DL_DIR).
Indeed.
>> The fact that this problem may or may not get solved by a later patch
>> in the series is more-or-less irrelevant here:
> Agreed. If that patch changes the behaviour, it is incorrect.
>> Peter is just saying
>> that the series is not perfectly bisectable, and he stopped reviewing
>> when he saw an issue in PATCH 03/14.
> And I do not see this issue...
Sorry, I got confused. The problem actually turned out to be the use of
pushd/popd with a /bin/sh, on here /bin/sh is dash which doesn't support
it.
The fix is to use !#/bin/bash
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-07-02 21:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 22:26 [Buildroot] [PATCH 0/14 v9] Some download-related changes (branch yem/check-downloads) Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 01/14] Makefile: add BR2_DL_DIR to EXTRA_ENV Yann E. MORIN
2014-07-02 15:24 ` Peter Korsgaard
2014-06-30 22:26 ` [Buildroot] [PATCH 02/14] pkg-infra: also set PKGDIR for the download step Yann E. MORIN
2014-07-02 15:24 ` Peter Korsgaard
2014-06-30 22:26 ` [Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script Yann E. MORIN
2014-07-02 15:28 ` Peter Korsgaard
2014-07-02 15:44 ` Thomas Petazzoni
2014-07-02 17:19 ` Thomas De Schampheleire
2014-07-02 17:22 ` Thomas Petazzoni
2014-07-02 17:31 ` Thomas De Schampheleire
2014-07-02 20:29 ` Yann E. MORIN
2014-07-02 20:31 ` Thomas Petazzoni
2014-07-02 20:37 ` Yann E. MORIN
2014-07-02 21:42 ` Peter Korsgaard [this message]
2014-07-02 20:25 ` Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 04/14] pkg-infra: move the svn " Yann E. MORIN
2014-07-01 14:07 ` Ryan Barnett
2014-06-30 22:26 ` [Buildroot] [PATCH 05/14] pkg-infra: move the cvs " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 06/14] pkg-infra: move the hg " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 07/14] pkg-infra: move the wget " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 08/14] pkg-infra: move the bzr " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 09/14] pkg-infra: move the scp " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 10/14] pkg-infra: move the cp (aka localfiles) " Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 11/14] pkg-infra: don't use DL_DIR as scratchpad for temporary downloads Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 12/14] pkg-infra: add possiblity to check downloaded files against known hashes Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 13/14] manual: add documentation about packages' hashes Yann E. MORIN
2014-06-30 22:26 ` [Buildroot] [PATCH 14/14] package/ca-certificates: add tarball's hashes Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2014-06-13 23:11 [Buildroot] [PATCH 0/14 v8] Some download-related changes (branch yem/check-downloads) Yann E. MORIN
2014-06-13 23:11 ` [Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g3vbfou.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox