* [Buildroot] [PATCH] perl-net-ssleay: fix build
@ 2014-07-03 13:31 Francois Perrad
2014-07-03 14:34 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Francois Perrad @ 2014-07-03 13:31 UTC (permalink / raw)
To: buildroot
add $(2)_CONV_ENV in perl infrastructure
see http://autobuild.buildroot.net/results/135/135867ef85535863e3647cc5fb82accb6f77612c/
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/perl-net-ssleay/perl-net-ssleay.mk | 7 +++++++
package/pkg-perl.mk | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk
index 413fdf0..48ff715 100644
--- a/package/perl-net-ssleay/perl-net-ssleay.mk
+++ b/package/perl-net-ssleay/perl-net-ssleay.mk
@@ -11,4 +11,11 @@ PERL_NET_SSLEAY_DEPENDENCIES = perl openssl
PERL_NET_SSLEAY_LICENSE = OpenSSL
PERL_NET_SSLEAY_LICENSE_FILES = LICENSE
+PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
+
+define PERL_NET_SSLEAY_FIX_MAKEFILE
+ $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile
+endef
+PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE
+
$(eval $(perl-package))
diff --git a/package/pkg-perl.mk b/package/pkg-perl.mk
index 5cfdc77..8c45001 100644
--- a/package/pkg-perl.mk
+++ b/package/pkg-perl.mk
@@ -49,6 +49,7 @@ ifeq ($(4),target)
# Configure package for target
define $(2)_CONFIGURE_CMDS
cd $$($$(PKG)_SRCDIR) && if [ -f Build.PL ] ; then \
+ $$($(2)_CONF_ENV) \
PERL_MM_USE_DEFAULT=1 \
perl Build.PL \
--config ar="$$(TARGET_AR)" \
@@ -69,6 +70,7 @@ define $(2)_CONFIGURE_CMDS
--install_path libdoc=/usr/share/man/man3 \
$$($(2)_CONF_OPT); \
else \
+ $$($(2)_CONF_ENV) \
PERL_MM_USE_DEFAULT=1 \
PERL_AUTOINSTALL=--skipdeps \
perl Makefile.PL \
@@ -95,12 +97,14 @@ else
# Configure package for host
define $(2)_CONFIGURE_CMDS
cd $$($$(PKG)_SRCDIR) && if [ -f Build.PL ] ; then \
+ $$($(2)_CONF_ENV) \
PERL_MM_USE_DEFAULT=1 \
perl Build.PL \
--install_base $$(HOST_DIR)/usr \
--installdirs vendor \
$$($(2)_CONF_OPT); \
else \
+ $$($(2)_CONF_ENV) \
PERL_MM_USE_DEFAULT=1 \
PERL_AUTOINSTALL=--skipdeps \
perl Makefile.PL \
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] perl-net-ssleay: fix build
2014-07-03 13:31 [Buildroot] [PATCH] perl-net-ssleay: fix build Francois Perrad
@ 2014-07-03 14:34 ` Peter Korsgaard
2014-07-03 18:13 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2014-07-03 14:34 UTC (permalink / raw)
To: buildroot
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:
> add $(2)_CONV_ENV in perl infrastructure
Please send that as a seperate patch.
> see http://autobuild.buildroot.net/results/135/135867ef85535863e3647cc5fb82accb6f77612c/
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/perl-net-ssleay/perl-net-ssleay.mk | 7 +++++++
> package/pkg-perl.mk | 4 ++++
> 2 files changed, 11 insertions(+)
> diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk
> index 413fdf0..48ff715 100644
> --- a/package/perl-net-ssleay/perl-net-ssleay.mk
> +++ b/package/perl-net-ssleay/perl-net-ssleay.mk
> @@ -11,4 +11,11 @@ PERL_NET_SSLEAY_DEPENDENCIES = perl openssl
> PERL_NET_SSLEAY_LICENSE = OpenSSL
> PERL_NET_SSLEAY_LICENSE_FILES = LICENSE
> +PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
> +
> +define PERL_NET_SSLEAY_FIX_MAKEFILE
> + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile
What about BR2_PREFER_STATIC_LIB builds?
Looking at the build failure, the problem seems to be about a mix of
host and target flags (E.G. the -L/usr/lib), rather than anything about
static/shared linking.
> +endef
> +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE
> +
> $(eval $(perl-package))
> diff --git a/package/pkg-perl.mk b/package/pkg-perl.mk
> index 5cfdc77..8c45001 100644
> --- a/package/pkg-perl.mk
> +++ b/package/pkg-perl.mk
> @@ -49,6 +49,7 @@ ifeq ($(4),target)
> # Configure package for target
> define $(2)_CONFIGURE_CMDS
> cd $$($$(PKG)_SRCDIR) && if [ -f Build.PL ] ; then \
> + $$($(2)_CONF_ENV) \
> PERL_MM_USE_DEFAULT=1 \
> perl Build.PL \
> --config ar="$$(TARGET_AR)" \
> @@ -69,6 +70,7 @@ define $(2)_CONFIGURE_CMDS
> --install_path libdoc=/usr/share/man/man3 \
> $$($(2)_CONF_OPT); \
> else \
> + $$($(2)_CONF_ENV) \
> PERL_MM_USE_DEFAULT=1 \
> PERL_AUTOINSTALL=--skipdeps \
> perl Makefile.PL \
> @@ -95,12 +97,14 @@ else
> # Configure package for host
> define $(2)_CONFIGURE_CMDS
> cd $$($$(PKG)_SRCDIR) && if [ -f Build.PL ] ; then \
> + $$($(2)_CONF_ENV) \
> PERL_MM_USE_DEFAULT=1 \
> perl Build.PL \
> --install_base $$(HOST_DIR)/usr \
> --installdirs vendor \
> $$($(2)_CONF_OPT); \
> else \
> + $$($(2)_CONF_ENV) \
> PERL_MM_USE_DEFAULT=1 \
> PERL_AUTOINSTALL=--skipdeps \
> perl Makefile.PL \
> --
> 1.9.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] perl-net-ssleay: fix build
@ 2014-08-16 7:11 Francois Perrad
2014-08-16 7:28 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Francois Perrad @ 2014-08-16 7:11 UTC (permalink / raw)
To: buildroot
the new option OPTIMIZE needs the same replacement.
see http://autobuild.buildroot.net/results/278f9d121273a16cedc009c0b8df0a8659d8fb73/
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/perl-net-ssleay/perl-net-ssleay.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk
index 9e9b8a7..b17975c 100644
--- a/package/perl-net-ssleay/perl-net-ssleay.mk
+++ b/package/perl-net-ssleay/perl-net-ssleay.mk
@@ -15,10 +15,11 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE
# suffers from: don't search for openssl, they pick the host-system one.
PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
-# Remove problematic single quotes in LDDLFLAGS & CCFLAGS definition
+# Remove problematic single quotes in LDDLFLAGS, CCFLAGS & OPTIMIZE definition
define PERL_NET_SSLEAY_FIX_MAKEFILE
$(SED) "s/^LDDLFLAGS = '\(.*\)'/LDDLFLAGS = \1/" $(@D)/Makefile
$(SED) "s/^CCFLAGS = '\(.*\)'/CCFLAGS = \1/" $(@D)/Makefile
+ $(SED) "s/^OPTIMIZE = '\(.*\)'/OPTIMIZE = \1/" $(@D)/Makefile
endef
PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] perl-net-ssleay: fix build
2014-08-16 7:11 Francois Perrad
@ 2014-08-16 7:28 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-08-16 7:28 UTC (permalink / raw)
To: buildroot
Dear Francois Perrad,
On Sat, 16 Aug 2014 09:11:10 +0200, Francois Perrad wrote:
> the new option OPTIMIZE needs the same replacement.
>
> see http://autobuild.buildroot.net/results/278f9d121273a16cedc009c0b8df0a8659d8fb73/
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/perl-net-ssleay/perl-net-ssleay.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-16 7:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-03 13:31 [Buildroot] [PATCH] perl-net-ssleay: fix build Francois Perrad
2014-07-03 14:34 ` Peter Korsgaard
2014-07-03 18:13 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2014-08-16 7:11 Francois Perrad
2014-08-16 7:28 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox