* [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr
@ 2014-07-03 16:32 Baruch Siach
2014-07-03 18:14 ` Thomas Petazzoni
2014-07-04 21:22 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2014-07-03 16:32 UTC (permalink / raw)
To: buildroot
Since we are only need to know whether the compiler runs successfully, and
stderr is empty for the success case, there is no need to redirect stderr to
/dev/null. Moreover, stderr output of the failing case reveals valuable
information on the real failure reason.
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
toolchain/helpers.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index c85968054012..8eb71efc19eb 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -298,7 +298,7 @@ check_arm_abi = \
echo "External toolchain uses the unsuported OABI" ; \
exit 1 ; \
fi ; \
- if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - 2>/dev/null; then \
+ if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - ; then \
abistr_$(BR2_ARM_EABI)='EABI'; \
abistr_$(BR2_ARM_EABIHF)='EABIhf'; \
echo "Incorrect ABI setting: $${abistr_y} selected, but toolchain is incompatible"; \
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr
2014-07-03 16:32 [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr Baruch Siach
@ 2014-07-03 18:14 ` Thomas Petazzoni
2014-07-04 21:22 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-07-03 18:14 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Thu, 3 Jul 2014 19:32:58 +0300, Baruch Siach wrote:
> Since we are only need to know whether the compiler runs successfully, and
s/are//
> stderr is empty for the success case, there is no need to redirect stderr to
> /dev/null. Moreover, stderr output of the failing case reveals valuable
> information on the real failure reason.
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr
2014-07-03 16:32 [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr Baruch Siach
2014-07-03 18:14 ` Thomas Petazzoni
@ 2014-07-04 21:22 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-07-04 21:22 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Since we are only need to know whether the compiler runs successfully, and
> stderr is empty for the success case, there is no need to redirect stderr to
> /dev/null. Moreover, stderr output of the failing case reveals valuable
> information on the real failure reason.
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-04 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-03 16:32 [Buildroot] [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr Baruch Siach
2014-07-03 18:14 ` Thomas Petazzoni
2014-07-04 21:22 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox