Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v2 1/3] pkg-perl: add $(2)_CONV_ENV
Date: Thu, 3 Jul 2014 20:18:00 +0200	[thread overview]
Message-ID: <20140703201800.6aa9b79f@free-electrons.com> (raw)
In-Reply-To: <1404406406-9209-1-git-send-email-francois.perrad@gadz.org>

Dear Francois Perrad,

On Thu,  3 Jul 2014 18:53:24 +0200, Francois Perrad wrote:
> in some case $(2)_CONV_OPT is not enough

In title and commit log: s/CONV/CONF/. Also please try to write more
detailed commit messages, such as:

"""
pkg-perl: add support for $(2)_CONF_ENV

This commit adds support for specifying additional variables to be
passed in the perl Makefile.PL or perl Build.PL executions for packages
based on the perl-package infrastructure.
"""

> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  docs/manual/adding-packages-perl.txt | 4 ++++
>  package/pkg-perl.mk                  | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/docs/manual/adding-packages-perl.txt b/docs/manual/adding-packages-perl.txt
> index 4062646..5046618 100644
> --- a/docs/manual/adding-packages-perl.txt
> +++ b/docs/manual/adding-packages-perl.txt
> @@ -100,6 +100,10 @@ A few additional variables, specific to the Perl/CPAN infrastructure,
>  can also be defined. Many of them are only useful in very specific
>  cases, typical packages will therefore only use a few of them.
>  
> +* +PERL_FOO_ENV_OPT+/+HOST_PERL_FOO_ENV_OPT+, to specify additional

The name of the options is incorrect here, it should be
PERL_FOO_CONF_ENV and HOST_PERL_FOO_CONV_ENV.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2014-07-03 18:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 16:53 [Buildroot] [v2 1/3] pkg-perl: add $(2)_CONV_ENV Francois Perrad
2014-07-03 16:53 ` [Buildroot] [v2 2/3] perl-net-ssleay: fix build Francois Perrad
2014-07-03 18:18   ` Thomas Petazzoni
2014-07-03 16:53 ` [Buildroot] [v2 3/3] " Francois Perrad
2014-07-03 18:20   ` Thomas Petazzoni
2014-07-13 13:35   ` Yann E. MORIN
2014-07-14 19:52     ` François Perrad
2014-07-14 22:43       ` Yann E. MORIN
2014-07-14 23:22         ` Yann E. MORIN
2014-07-14 23:49           ` Yann E. MORIN
2014-07-03 18:18 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140703201800.6aa9b79f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox