From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v2 3/3] perl-net-ssleay: fix build
Date: Thu, 3 Jul 2014 20:20:12 +0200 [thread overview]
Message-ID: <20140703202012.580a0f68@free-electrons.com> (raw)
In-Reply-To: <1404406406-9209-3-git-send-email-francois.perrad@gadz.org>
Dear Francois Perrad,
See: this patch has exactly the same title as the previous one. That's
a good indication that the title is not sufficiently distinctive.
On Thu, 3 Jul 2014 18:53:26 +0200, Francois Perrad wrote:
> the following error occurs after the previous patch
> arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared '
>
> so, force LDDLFLAGS without quote
>
> note: previously LDDLFLAGS was correct
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/perl-net-ssleay/perl-net-ssleay.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk
> index 7e4c194..48ff715 100644
> --- a/package/perl-net-ssleay/perl-net-ssleay.mk
> +++ b/package/perl-net-ssleay/perl-net-ssleay.mk
> @@ -13,4 +13,9 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE
>
> PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
>
> +define PERL_NET_SSLEAY_FIX_MAKEFILE
> + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile
> +endef
> +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE
What about BR2_PREFER_STATIC_LIB=y configurations, as Peter asked in
the review of your initial patch?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-03 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 16:53 [Buildroot] [v2 1/3] pkg-perl: add $(2)_CONV_ENV Francois Perrad
2014-07-03 16:53 ` [Buildroot] [v2 2/3] perl-net-ssleay: fix build Francois Perrad
2014-07-03 18:18 ` Thomas Petazzoni
2014-07-03 16:53 ` [Buildroot] [v2 3/3] " Francois Perrad
2014-07-03 18:20 ` Thomas Petazzoni [this message]
2014-07-13 13:35 ` Yann E. MORIN
2014-07-14 19:52 ` François Perrad
2014-07-14 22:43 ` Yann E. MORIN
2014-07-14 23:22 ` Yann E. MORIN
2014-07-14 23:49 ` Yann E. MORIN
2014-07-03 18:18 ` [Buildroot] [v2 1/3] pkg-perl: add $(2)_CONV_ENV Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703202012.580a0f68@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox