Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] ncursesw package fixes
@ 2014-07-04 17:02 Gustavo Zacarias
  2014-07-04 17:03 ` [Buildroot] [PATCH 1/2] nano: enable ncursesw support Gustavo Zacarias
  2014-07-04 17:03 ` [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses Gustavo Zacarias
  0 siblings, 2 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2014-07-04 17:02 UTC (permalink / raw)
  To: buildroot

This series fixes issues with packages when ncurses is built with widechar
support. This depends on the not-yet-applied patch from Jeremy Kerr
[package/ncurses: Allow building wide char support] to be of any real use,
however they shouldn't break anything if that's not applied since the
conditions are the same for ncurses without wchar.

Gustavo Zacarias (2):
  nano: enable ncursesw support
  statserial: don't link against legacy curses

 package/nano/nano.mk                                |  9 +++++++--
 package/statserial/statserial-01-ncurses-link.patch | 16 ++++++++++++++++
 2 files changed, 23 insertions(+), 2 deletions(-)
 create mode 100644 package/statserial/statserial-01-ncurses-link.patch

-- 
1.8.5.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] nano: enable ncursesw support
  2014-07-04 17:02 [Buildroot] [PATCH 0/2] ncursesw package fixes Gustavo Zacarias
@ 2014-07-04 17:03 ` Gustavo Zacarias
  2014-07-04 17:03 ` [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses Gustavo Zacarias
  1 sibling, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2014-07-04 17:03 UTC (permalink / raw)
  To: buildroot

Enable support for ncurses widechar by specifying the proper
ncursesw-config when it's enabled, otherwise keep the old trick in place
when it's not to avoid automatically picking up the host/distro one.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/nano/nano.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/nano/nano.mk b/package/nano/nano.mk
index 2b6df3a..130fe83 100644
--- a/package/nano/nano.mk
+++ b/package/nano/nano.mk
@@ -9,11 +9,16 @@ NANO_VERSION = $(NANO_VERSION_MAJOR).2
 NANO_SITE = http://www.nano-editor.org/dist/v$(NANO_VERSION_MAJOR)
 NANO_LICENSE = GPLv3+
 NANO_LICENSE_FILES = COPYING
-NANO_MAKE_ENV = CURSES_LIB="-lncurses"
 NANO_CONF_OPT = --without-slang
-NANO_CONF_ENV = ac_cv_prog_NCURSESW_CONFIG=false
 NANO_DEPENDENCIES = ncurses
 
+ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
+	NANO_CONF_ENV += ac_cv_prog_NCURSESW_CONFIG="$(STAGING_DIR)/usr/bin/ncursesw5-config"
+else
+	NANO_CONF_ENV += ac_cv_prog_NCURSESW_CONFIG=false
+	NANO_MAKE_ENV += CURSES_LIB="-lncurses"
+endif
+
 ifeq ($(BR2_PACKAGE_FILE),y)
 	NANO_DEPENDENCIES += file
 else
-- 
1.8.5.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses
  2014-07-04 17:02 [Buildroot] [PATCH 0/2] ncursesw package fixes Gustavo Zacarias
  2014-07-04 17:03 ` [Buildroot] [PATCH 1/2] nano: enable ncursesw support Gustavo Zacarias
@ 2014-07-04 17:03 ` Gustavo Zacarias
  2014-07-15 18:54   ` Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2014-07-04 17:03 UTC (permalink / raw)
  To: buildroot

Link against libncurses instead of the legacy libcurses.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/statserial/statserial-01-ncurses-link.patch | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 package/statserial/statserial-01-ncurses-link.patch

diff --git a/package/statserial/statserial-01-ncurses-link.patch b/package/statserial/statserial-01-ncurses-link.patch
new file mode 100644
index 0000000..b1c41e6
--- /dev/null
+++ b/package/statserial/statserial-01-ncurses-link.patch
@@ -0,0 +1,16 @@
+Link to libncurses instead of the legacy libcurses.
+
+Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+
+diff -Nura statserial-1.1.orig/Makefile statserial-1.1/Makefile
+--- statserial-1.1.orig/Makefile	2014-07-04 12:47:41.279440415 -0300
++++ statserial-1.1/Makefile	2014-07-04 12:47:47.948665740 -0300
+@@ -10,7 +10,7 @@
+ LDFLAGS = -s -N
+ 
+ statserial:	statserial.o
+-	$(LD) $(LDFLAGS) -o statserial statserial.o -lcurses
++	$(LD) $(LDFLAGS) -o statserial statserial.o -lncurses
+ 
+ statserial.o: statserial.c
+ 	$(CC) $(CFLAGS) -c statserial.c
-- 
1.8.5.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses
  2014-07-04 17:03 ` [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses Gustavo Zacarias
@ 2014-07-15 18:54   ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2014-07-15 18:54 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Fri,  4 Jul 2014 14:03:01 -0300, Gustavo Zacarias wrote:
> Link against libncurses instead of the legacy libcurses.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/statserial/statserial-01-ncurses-link.patch | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 package/statserial/statserial-01-ncurses-link.patch

Applied, thanks. I was going to say "and please send upstream", but
then I realized that there is pretty no upstream for statserial...

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-15 18:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-04 17:02 [Buildroot] [PATCH 0/2] ncursesw package fixes Gustavo Zacarias
2014-07-04 17:03 ` [Buildroot] [PATCH 1/2] nano: enable ncursesw support Gustavo Zacarias
2014-07-04 17:03 ` [Buildroot] [PATCH 2/2] statserial: don't link against legacy curses Gustavo Zacarias
2014-07-15 18:54   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox