* [Buildroot] [PATCH] infra: fix "<pkg>-rebuild" when using rsync source feature
@ 2014-06-30 9:51 Fabio Porcedda
2014-07-15 20:45 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Porcedda @ 2014-06-30 9:51 UTC (permalink / raw)
To: buildroot
Because the configure stamp file depends on the rsync stamp file,
removing it by the "<pkg>-clean-for-rebuild" rule trigger the configure
step. To avoid triggering the configure step use an order-only dependency.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Reported-by: C?dric Marie <cedric.marie@openmailbox.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/pkg-generic.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 54193d2..3c05a94 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -544,7 +544,10 @@ else
# source, by rsyncing
# depends
# configure
-$$($(2)_TARGET_CONFIGURE): $$($(2)_TARGET_RSYNC)
+
+# Use an order-only dependency so the "<pkg>-clean-for-rebuild" rule
+# can remove the stamp file without triggering the configure step.
+$$($(2)_TARGET_CONFIGURE): | $$($(2)_TARGET_RSYNC)
$(1)-depends: $$($(2)_FINAL_DEPENDENCIES)
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] infra: fix "<pkg>-rebuild" when using rsync source feature
2014-06-30 9:51 [Buildroot] [PATCH] infra: fix "<pkg>-rebuild" when using rsync source feature Fabio Porcedda
@ 2014-07-15 20:45 ` Thomas Petazzoni
2014-07-16 6:29 ` Cédric Marie
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2014-07-15 20:45 UTC (permalink / raw)
To: buildroot
Dear Fabio Porcedda,
On Mon, 30 Jun 2014 11:51:28 +0200, Fabio Porcedda wrote:
> Because the configure stamp file depends on the rsync stamp file,
> removing it by the "<pkg>-clean-for-rebuild" rule trigger the configure
> step. To avoid triggering the configure step use an order-only dependency.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Reported-by: C?dric Marie <cedric.marie@openmailbox.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/pkg-generic.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] infra: fix "<pkg>-rebuild" when using rsync source feature
2014-07-15 20:45 ` Thomas Petazzoni
@ 2014-07-16 6:29 ` Cédric Marie
0 siblings, 0 replies; 3+ messages in thread
From: Cédric Marie @ 2014-07-16 6:29 UTC (permalink / raw)
To: buildroot
Le 2014-07-15 22:45, Thomas Petazzoni a ?crit?:
> Applied, thanks.
Thanks a lot :)
--
C?dric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-16 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 9:51 [Buildroot] [PATCH] infra: fix "<pkg>-rebuild" when using rsync source feature Fabio Porcedda
2014-07-15 20:45 ` Thomas Petazzoni
2014-07-16 6:29 ` Cédric Marie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox