Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
@ 2014-07-17 15:06 Andreas Naumann
  2014-07-17 16:52 ` Yann E. MORIN
  2014-07-18  7:12 ` Andreas Naumann
  0 siblings, 2 replies; 5+ messages in thread
From: Andreas Naumann @ 2014-07-17 15:06 UTC (permalink / raw)
  To: buildroot

The cp helperscript expects a filename as target, but just the folder name was given.
---
 package/pkg-download.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index 7f208d5..118591c 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -206,7 +206,7 @@ endef
 define DOWNLOAD_LOCALFILES
 	test -e $(DL_DIR)/$(2) || \
 	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
-					 $(DL_DIR) && \
+					 $(DL_DIR)/$(2) && \
 	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
 endef
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
  2014-07-17 15:06 [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES Andreas Naumann
@ 2014-07-17 16:52 ` Yann E. MORIN
  2014-07-18  7:12 ` Andreas Naumann
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-07-17 16:52 UTC (permalink / raw)
  To: buildroot

Andreas, All,

On 2014-07-17 17:06 +0200, Andreas Naumann spake thusly:
> The cp helperscript expects a filename as target, but just the folder name was given.

This is mising your Signed-off-by line. Care to just reply to your
initial mail to add it, please?

Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/pkg-download.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index 7f208d5..118591c 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -206,7 +206,7 @@ endef
>  define DOWNLOAD_LOCALFILES
>  	test -e $(DL_DIR)/$(2) || \
>  	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
> -					 $(DL_DIR) && \
> +					 $(DL_DIR)/$(2) && \
>  	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
>  endef
>  
> -- 
> 1.8.3.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
  2014-07-17 15:06 [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES Andreas Naumann
  2014-07-17 16:52 ` Yann E. MORIN
@ 2014-07-18  7:12 ` Andreas Naumann
  2014-07-18 16:46   ` Yann E. MORIN
  2014-07-18 18:02   ` Thomas Petazzoni
  1 sibling, 2 replies; 5+ messages in thread
From: Andreas Naumann @ 2014-07-18  7:12 UTC (permalink / raw)
  To: buildroot

 From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
From: Andreas Naumann <anaumann@ultratronik.de>
Date: Thu, 17 Jul 2014 16:47:02 +0200
Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES

The cp helperscript expects a filename as target, but just the folder 
name was given.

Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
---
  package/pkg-download.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index 7f208d5..118591c 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -206,7 +206,7 @@ endef
  define DOWNLOAD_LOCALFILES
  	test -e $(DL_DIR)/$(2) || \
  	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call 
qstrip,$(1))) \
-					 $(DL_DIR) && \
+					 $(DL_DIR)/$(2) && \
  	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
  endef

-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
  2014-07-18  7:12 ` Andreas Naumann
@ 2014-07-18 16:46   ` Yann E. MORIN
  2014-07-18 18:02   ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2014-07-18 16:46 UTC (permalink / raw)
  To: buildroot

Andreas, All,

On 2014-07-18 09:12 +0200, Andreas Naumann spake thusly:
> From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
> From: Andreas Naumann <anaumann@ultratronik.de>
> Date: Thu, 17 Jul 2014 16:47:02 +0200
> Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES
> 
> The cp helperscript expects a filename as target, but just the folder name
> was given.
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/pkg-download.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index 7f208d5..118591c 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -206,7 +206,7 @@ endef
>  define DOWNLOAD_LOCALFILES
>  	test -e $(DL_DIR)/$(2) || \
>  	$(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call
> qstrip,$(1))) \
> -					 $(DL_DIR) && \
> +					 $(DL_DIR)/$(2) && \
>  	$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
>  endef
> 
> -- 
> 1.8.3.2

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
  2014-07-18  7:12 ` Andreas Naumann
  2014-07-18 16:46   ` Yann E. MORIN
@ 2014-07-18 18:02   ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-07-18 18:02 UTC (permalink / raw)
  To: buildroot

Dear Andreas Naumann,

On Fri, 18 Jul 2014 09:12:09 +0200, Andreas Naumann wrote:
>  From 40ba2efd131a4fd70e44a0f9f96c4637da279df8 Mon Sep 17 00:00:00 2001
> From: Andreas Naumann <anaumann@ultratronik.de>
> Date: Thu, 17 Jul 2014 16:47:02 +0200
> Subject: [PATCH 1/6] pkg-infra: Fix DOWNLOAD_LOCALFILES
> 
> The cp helperscript expects a filename as target, but just the folder 
> name was given.
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> ---
>   package/pkg-download.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. But next time, could you use "git send-email" to send
your patch? Your patch was incorrectly line-wrapped, and the formatting
of the commit log a bit weird.

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-18 18:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 15:06 [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES Andreas Naumann
2014-07-17 16:52 ` Yann E. MORIN
2014-07-18  7:12 ` Andreas Naumann
2014-07-18 16:46   ` Yann E. MORIN
2014-07-18 18:02   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox